Hamburger menu updates #151
Conversation
There was a problem hiding this comment.
Everything works well! I'm still on the fence about having Rewards in the hamburger menu when it kind of disrupts the pattern of being able to swipe down to close it, but I do understand why it would be important to include in the menu. I trust @12aschen to make the decision on that!
| @@ -17,7 +17,7 @@ export default function ResourcesStackNavigator() { | |||
| return ( | |||
| <ResourcesStack.Navigator | |||
| screenOptions={{ | |||
| drawerLabel: 'Rewards', | |||
| drawerLabel: 'Resources', | |||
There was a problem hiding this comment.
- Menu items work!!
- Preserves scroll location/tab on resources and rewards - don't think this is a huge issue though
I do still think it's important to have rewards here to make it discoverable in two places! There was conflicting feedback on the green banner being discoverable (which .. would have been nice to get more user feedback on :'))) rip) but I think better safe than sorry!
|
Yeah I'm still super confused as to why |
What's new in this PR
MapScreendrawer label from "Stores" to "Map"How to review
Hamburger menu tabs should still operate as usual.
Use this Expo link to test on Android
Relevant Links
Online sources
Related PRs
Next steps
If possible, figure out how to make
StoresLista tab in the hamburger menu. I made some progress in this (andgit stashed it), up until the point where the tab displays and navigates to the stores list with all stores loaded in alphabetical order, but the changes made cause more problems than the good it'll do, so we're gonna backlog this for now. :(Namely, when clicking on store cards, the map screen doesn't update the current store. Also, the tab doesn't always navigate to the
StoresListscreen.Screenshots
CC: @anniero98 @wangannie