Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewards screen swipe transition from hamburger menu #154

Merged
merged 4 commits into from
May 11, 2020
Merged

Rewards screen swipe transition from hamburger menu #154

merged 4 commits into from
May 11, 2020

Conversation

thumn
Copy link
Contributor

@thumn thumn commented May 11, 2020

What's new in this PR

  • @wangannie's swipe transition fix for the rewards screen when accessed via hamburger menu
  • Code cleanup in drawer menu
  • Removed rewards stack

How to review

  • Check that opening and closing the rewards screen via swipe and down arrow button works from the hamburger menu

Relevant Links

Online sources

Related PRs

#151

Next steps

Screenshots

CC: @anniero98 @wangannie

@thumn thumn requested a review from wangannie May 11, 2020 03:56
wangannie
wangannie approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@wangannie wangannie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wangannie wangannie merged commit e681415 into master May 11, 2020
@wangannie wangannie deleted the thu/rewards-transition branch May 11, 2020 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangannie wangannie wangannie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thumn @wangannie