Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product details styling #64

Merged
merged 3 commits into from
Apr 3, 2020
Merged

Product details styling #64

merged 3 commits into from
Apr 3, 2020

Conversation

wangannie
Copy link
Member

What's new in this PR

Relevant Links

Online sources

Related PRs

How to review

  • See if everything looks right and works as expected.

Next steps

Tests Performed, Edge Cases

Screenshots

image

CC: @anniero98 @wangannie

@wangannie wangannie self-assigned this Mar 30, 2020
@wangannie wangannie requested a review from kennethlien March 31, 2020 01:21
marginLeft: 20,
marginRight: 8,
}}>
<ProductInfo style={{ flexShrink: 2 }} product={currentProduct} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't find any weird looking things here, but I was testing on iPad so it might be inaccurate.

@annieyro annieyro changed the base branch from master to justin/README_changes April 3, 2020 02:49
@annieyro annieyro changed the base branch from justin/README_changes to master April 3, 2020 02:50
@wangannie wangannie merged commit 836d077 into master Apr 3, 2020
@wangannie wangannie deleted the AnnieW/product_detail_styling branch April 3, 2020 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants