-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc. styling cleanup, empty states, 'notch' adjustment, Android bug fixes #56
Conversation
…chen into AnnieW/navigation_styling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woah this is a really pretty PR. I can't run the android one but the empty states were a great add!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on iPhone 11! :- ) thank u for hard worker
…chen into AnnieW/stores_list_cleanup
What's new in this PR
Continuation from #45. Lots of scattered styling detail cleanup/finishing touches, empty states, and fixing Android issues.
StoreList
,StoreProducts
,Rewards
, andPointsHistory
fromScrollView
toFlatList
for performance enhancements with lazy loading and easy empty states.NavHeaderContainer
to a functional component to use detect safe area insets and adjust navigation heading heights depending on if the device has a notch.NavHeaderContainer
in Rewards for consistency (it is now used on every nav header container)MapView
that is only raised on Android that would crash upon opening the map.Layout.js
window width and height constants.Relevant Links
Online sources
This helped me get rid of those unique key warnings: https://stackoverflow.com/questions/44545148/basic-flatlist-code-throws-warning-react-native
Related PRs
This is a continuation of #45. This handled most of the todos from #34.
How to review
Next steps
https://www.loom.com/share/c58f93863e7e422490653db4f73adf91
Tests Performed, Edge Cases
Screenshots
iPhone 8, iPhone 11, Pixel 3XL (left to right)
Rewards & Points History: responsive nav heading & empty states
![](https://user-images.githubusercontent.com/21160510/77836003-84855480-710f-11ea-98ed-8cb5f9fc03fa.png)
Products empty state
CC: @anniero98 @wangannie