Responsive BottomSheet #71
Conversation
screens/map/MapScreen.js
Outdated
|
|
||
| MapScreen.navigationOptions = { | ||
| headerShown: false, | ||
| }; |
There was a problem hiding this comment.
Don't need this anymore -- I deleted these in a navigation clean up in #56
There was a problem hiding this comment.
On second thought this will get removed in the merge
.vscode/settings.json
Outdated
| "files.associations": { |
There was a problem hiding this comment.
Wait these shouldn't be in here right..
There was a problem hiding this comment.
This is strange - even though I inevitably caused these changes due to format on save (no way to turn it off somehow) but what I've changed it to is what is currently reflected in master so I'm hoping..that might be ok?
screens/map/MapScreen.js
Outdated
| @@ -20,6 +20,9 @@ import { | |||
| SearchBar, | |||
| } from '../../styled/store'; | |||
|
|
|||
| const minSnapPoint = 300; | |||
There was a problem hiding this comment.
Were you going to comment/document how these were determined?
There was a problem hiding this comment.
I was going to, but the math does not really add up and was done largely by trial and error. Should I still have it down?
screens/map/MapScreen.js
Outdated
| @@ -20,6 +20,9 @@ import { | |||
| SearchBar, | |||
| } from '../../styled/store'; | |||
|
|
|||
| const minSnapPoint = 300; | |||
There was a problem hiding this comment.
Also this should be a little higher. In Figma you should be able to peek the images https://www.figma.com/file/drhxZht9Mvogrc6aLn7MsK/Spring-20-DC-Central-Kitchen?node-id=7827%3A55
There was a problem hiding this comment.
Changed minSnapPoint to 325, which is a little higher (16px vs 11px in figma) but given that our current product cards do not have backgrounds, I gave it a little bump to show at least some parts of the product image. Feel free to change it to something that makes more sense in terms of design decision!
…chen into tommy/responsive_bottomsheet
|
Added minimum snap point for map accessibility on really small phones like the iPhone SE. |
What's new in this PR
pts)Relevant Links
How to review
Next steps
Tests Performed, Edge Cases
Screenshots
CC: @wangannie