Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support completion condition for multi-instance #2641

Closed
korthout opened this issue Dec 16, 2021 · 4 comments · Fixed by #2709
Closed

Support completion condition for multi-instance #2641

korthout opened this issue Dec 16, 2021 · 4 comments · Fixed by #2709
Labels
enhancement New feature or request
Milestone

Comments

@korthout
Copy link
Member

korthout commented Dec 16, 2021

Is your feature request related to a problem? Please describe.

Zeebe will gain support for completion condition for multi-instance with camunda/camunda#8321. Users should be able to model this expression in the modeler, instead of having to change the XML directly.

Describe the solution you'd like

I want to be able to set the completion condition expression for multi-instance elements from the modeler's properties panel.

In the properties panel, under Multi-Instance, a new input field could be added that:

  • when some text is entered, it creates the <completionCondition> element inside the <multiInstanceLoopCharacteristics> element if the completionCondition element does not yet exist, and always updates the content of the element with the provided text
  • when the text is removed, it removes the <completionCondition> element from the <multiInstanceLoopCharacteristics> element.

Describe alternatives you've considered

None

Additional context

In the xml, a multi-instance element has a <multiInstanceLoopCharacteristics> child element. This multiInstanceLoopCharacteristics element should have a child element <completionCondition> which itself contains the expression as content. See BPMN/2.0.2 pages 192, 198, 432 and 433.

Zeebe expects the completion condition to be a FEEL-expression that evaluates to a boolean value.
Zeebe expects FEEL-expression to be prefixed by =.

See: bpmn-io/bpmn-js-properties-panel#530

@korthout korthout added the enhancement New feature or request label Dec 16, 2021
@MaxTru MaxTru added this to the M52 milestone Dec 17, 2021
@MaxTru MaxTru added the ready Ready to be worked on label Dec 17, 2021 — with bpmn-io-tasks
@MaxTru MaxTru added the needs review Review pending label Jan 3, 2022 — with bpmn-io-tasks
@MaxTru MaxTru removed the ready Ready to be worked on label Jan 3, 2022
@pinussilvestrus pinussilvestrus added fixed upstream Requires integration of upstream change and removed needs review Review pending labels Jan 6, 2022
barmac added a commit that referenced this issue Jan 26, 2022
Closes #2664
Closes #2374
Closes #2524
Closes #2641
Closes #2599
Closes #2585
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed fixed upstream Requires integration of upstream change labels Jan 26, 2022
barmac added a commit that referenced this issue Jan 27, 2022
Closes #2664
Closes #2374
Closes #2524
Closes #2641
Closes #2599
Closes #2585
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jan 27, 2022
@korthout
Copy link
Member Author

@barmac Thanks for the fix. I see that this is connected to the 5.0.0-alpha release. Will that be the next generally available modeler version? Or will there be a stable release that will contain this feature?

@barmac
Copy link
Collaborator

barmac commented Jan 27, 2022

The alpha is already available publicly at https://downloads.camunda.cloud/release/camunda-modeler/5.0.0-alpha.0/ Feel free to check it out and share your feedback.

@korthout
Copy link
Member Author

korthout commented Jan 27, 2022

@barmac I'm asking because of camunda/camunda-docs#509 (review). We want to publish the documentation once this feature is supported by the modeler. Is the alpha release a real release, or just something to try out stuff? If it's not stable, is there another stable release on the horizon?

@barmac
Copy link
Collaborator

barmac commented Jan 27, 2022

Let's sync via DM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants