Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use two tones of grey for the section actions #2664

Closed
andreasgeier opened this issue Jan 11, 2022 · 1 comment · Fixed by #2709
Closed

Don't use two tones of grey for the section actions #2664

andreasgeier opened this issue Jan 11, 2022 · 1 comment · Fixed by #2709
Labels
good first issue Good for newcomers spring cleaning Could be cleaned up one day ux

Comments

@andreasgeier
Copy link

What should we do?

The expand/collapse arrows in the new properties panel change their color, depending on whether the section is marked as edited or not.

Screen Shot 2022-01-11 at 14 55 33

This is repetitive information.
Moreover, we learned from user feedback, that the greyed-out arrows may perceived as disabled.

Solution: Use the same dark grey for all section arrows.

Screen Shot 2022-01-11 at 14 58 25

Same for the create (plus) button: use the same dark grey to avoid the association with being disabled.

Screen Shot 2022-01-11 at 15 17 53

Why should we do it?

See above.
@andreasgeier andreasgeier added good first issue Good for newcomers spring cleaning Could be cleaned up one day ux backlog Queued in backlog labels Jan 11, 2022
MaxTru added a commit to bpmn-io/properties-panel that referenced this issue Jan 14, 2022
@MaxTru
style: use consistent add/arrow color also for empty sections
5179bed 
fixes upstream camunda/camunda-modeler#2664
@MaxTru MaxTru mentioned this issue Jan 14, 2022
Merged
MaxTru added a commit to bpmn-io/properties-panel that referenced this issue Jan 14, 2022
@MaxTru
style: use consistent add/arrow color also for empty sections
7f279ec 
fixes upstream camunda/camunda-modeler#2664
@MaxTru MaxTru added needs review Review pending and removed backlog Queued in backlog labels Jan 14, 2022
MaxTru added a commit to bpmn-io/properties-panel that referenced this issue Jan 17, 2022
@MaxTru
style: use consistent add/arrow color also for empty sections
272d4be 
fixes upstream camunda/camunda-modeler#2664
@MaxTru
Copy link
Contributor

MaxTru commented Jan 17, 2022 •
edited
Loading

Fixed upstream via bpmn-io/properties-panel#130

@MaxTru MaxTru closed this as completed Jan 17, 2022
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jan 17, 2022
@MaxTru MaxTru added the fixed upstream Requires integration of upstream change label Jan 20, 2022
@MaxTru MaxTru reopened this Jan 20, 2022
barmac added a commit that referenced this issue Jan 26, 2022
@barmac
deps: update dependencies
3e3b760 
Closes #2664
Closes #2374
Closes #2524
Closes #2641
Closes #2599
Closes #2585
@barmac barmac mentioned this issue Jan 26, 2022
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed fixed upstream Requires integration of upstream change labels Jan 26, 2022
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jan 27, 2022
barmac added a commit that referenced this issue Jan 27, 2022
@barmac
deps: update dependencies
a7b1626 
Closes #2664
Closes #2374
Closes #2524
Closes #2641
Closes #2599
Closes #2585
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers spring cleaning Could be cleaned up one day ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deps: update dependencies camunda/camunda-modeler
2 participants
@andreasgeier @MaxTru