Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feel editor reports syntaxError for escaped variable names #3338

Open
3 of 7 tasks
datakurre opened this issue Dec 5, 2022 · 4 comments
Open
3 of 7 tasks

Feel editor reports syntaxError for escaped variable names #3338

datakurre opened this issue Dec 5, 2022 · 4 comments
Assignees
Labels
bug Something isn't working channel:support feel editing linting ready Ready to be worked on

Comments

@datakurre
Copy link

datakurre commented Dec 5, 2022

Describe the bug

Feel supports escaping variable names, because they are allowed to contains spaces, special characters, dots, etc...

https://camunda.github.io/feel-scala/docs/reference/language-guide/feel-variables/#escape-variable-names

Using variable escaping in a FEEL expression shows red syntaxError: expression expected in modeler 5.6.0-nightly-20221204

Steps to reproduce

  1. create C8 BPMN and in any FEEL expression input type text with bacticks as in https://camunda.github.io/feel-scala/docs/reference/language-guide/feel-variables/#escape-variable-names
  2. red syntaxError: expression expected / Unparsable FEEL expression is shown

Expected behavior

Escaped variables names should be supported as in feel-scala docs. (Deployed process with backtick-escaped variable names does work just fine.)

Environment

  • Camunda Modeler Version: 5.6.0-nightly.20221204

Additional context


The fix for this issue is to enable the camunda dialect (cf. nikku/lezer-feel#37) into our editing stack, and activate it inside the FEEL editors used.

Work items

@datakurre datakurre added the bug Something isn't working label Dec 5, 2022
@nikku
Copy link
Member

nikku commented Dec 5, 2022

@datakurre FEEL does not support escaping variable names. That one is a Camunda syntax extension and we'll mark it appropriately in the next release of the documentation, too.

In the first iteration of our editor support we indeed support standard FEEL only. We're carefully monitoring user adoption and consider adding support for our syntax extensions in the future. On the other hand supporting "JUST FEEL" has it's value, too.

@nikku
Copy link
Member

nikku commented Dec 5, 2022

CC @christian-konrad

@datakurre
Copy link
Author

Thanks! I stand corrected, though surprised 😅

@nikku
Copy link
Member

nikku commented Apr 8, 2024

Reported again via internal feedback. User found the (now discouraged) backtick syntax not via documentation but via an older forum post.

@nikku nikku changed the title Feel editor reports syntaxError for escaped variable names Feel editor reports syntaxError for escaped variable names Apr 8, 2024
@nikku nikku self-assigned this Jan 22, 2025
@nikku nikku added ready Ready to be worked on and removed backlog Queued in backlog labels Jan 22, 2025
nikku added a commit to bpmn-io/feel-editor that referenced this issue Jan 23, 2025
This enables parser dialects (i.e. `camunda`), as supported by the
underlying language tooling, hence accepting backtick escaped variable
names such as `foo + bar`.

Related to camunda/camunda-modeler#3983
Related to camunda/camunda-modeler#3338
nikku added a commit to bpmn-io/feel-editor that referenced this issue Jan 23, 2025
This enables parser dialects (i.e. `camunda`), as supported by the
underlying language tooling, hence accepting backtick escaped variable
names such as `foo + bar`.

Related to camunda/camunda-modeler#3983
Related to camunda/camunda-modeler#3338
barmac pushed a commit to bpmn-io/feel-editor that referenced this issue Jan 23, 2025
This enables parser dialects (i.e. `camunda`), as supported by the
underlying language tooling, hence accepting backtick escaped variable
names such as `foo + bar`.

Related to camunda/camunda-modeler#3983
Related to camunda/camunda-modeler#3338
nikku added a commit to bpmn-io/feel-editor that referenced this issue Jan 23, 2025
This enables parser dialects (i.e. `camunda`), as supported by the
underlying language tooling, hence accepting backtick escaped variable
names such as `foo + bar`.

Related to camunda/camunda-modeler#3983
Related to camunda/camunda-modeler#3338
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working channel:support feel editing linting ready Ready to be worked on
Projects
None yet
Development

No branches or pull requests

2 participants