-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feel editor reports syntaxError
for escaped variable names
#3338
Comments
@datakurre FEEL does not support escaping variable names. That one is a Camunda syntax extension and we'll mark it appropriately in the next release of the documentation, too. In the first iteration of our editor support we indeed support standard FEEL only. We're carefully monitoring user adoption and consider adding support for our syntax extensions in the future. On the other hand supporting "JUST FEEL" has it's value, too. |
Thanks! I stand corrected, though surprised 😅 |
Reported again via internal feedback. User found the (now discouraged) backtick syntax not via documentation but via an older forum post. |
syntaxError
for escaped variable names
This enables parser dialects (i.e. `camunda`), as supported by the underlying language tooling, hence accepting backtick escaped variable names such as `foo + bar`. Related to camunda/camunda-modeler#3983 Related to camunda/camunda-modeler#3338
This enables parser dialects (i.e. `camunda`), as supported by the underlying language tooling, hence accepting backtick escaped variable names such as `foo + bar`. Related to camunda/camunda-modeler#3983 Related to camunda/camunda-modeler#3338
This enables parser dialects (i.e. `camunda`), as supported by the underlying language tooling, hence accepting backtick escaped variable names such as `foo + bar`. Related to camunda/camunda-modeler#3983 Related to camunda/camunda-modeler#3338
This enables parser dialects (i.e. `camunda`), as supported by the underlying language tooling, hence accepting backtick escaped variable names such as `foo + bar`. Related to camunda/camunda-modeler#3983 Related to camunda/camunda-modeler#3338
Describe the bug
Feel supports escaping variable names, because they are allowed to contains spaces, special characters, dots, etc...
https://camunda.github.io/feel-scala/docs/reference/language-guide/feel-variables/#escape-variable-names
Using variable escaping in a FEEL expression shows red
syntaxError: expression expected
in modeler 5.6.0-nightly-20221204Steps to reproduce
syntaxError: expression expected
/Unparsable FEEL expression
is shownExpected behavior
Escaped variables names should be supported as in feel-scala docs. (Deployed process with backtick-escaped variable names does work just fine.)
Environment
Additional context
The fix for this issue is to enable the
camunda
dialect (cf. nikku/lezer-feel#37) into our editing stack, and activate it inside the FEEL editors used.Work items
parserDialect
bpmn-io/feel-editor#68parserDialect=camunda
in BPMN editor (properties panel) (Adoptcamunda
parser dialect #4809)parserDialect=camunda
in DMN editor (expressions + properties panel) (Adoptcamunda
parser dialect #4809)parserDialect=camunda
when validating FEEL expressions inside of BPMN filesThe text was updated successfully, but these errors were encountered: