-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for camunda variable escaping extension #37
Conversation
I'm not sure if it's really a good idea to let the whole back tick content be a VariableName token or if it's better to use a separate token. |
Cf. #36 (comment) and previous comments. I think you want to declare it as a token extension. I'd be fine to accept a PR that implements this as a "camunda" dialect. |
I think the backtick content should be an Edit: If it was a |
The https://github.com/lezer-parser/javascript/blob/main/src/javascript.grammar |
72252bc
to
d404f51
Compare
Thanks for the feedback. I'll change the identifier next |
d404f51
to
52fa949
Compare
I'm not sure if that's what you meant but I've updated the grammar to extract a new BacktickIdentifier which is used in the VariableName |
* Adds `camunda` dialect * Adds support for backtick escaped variables, i.e. foo.`boo ba` * Must be explicitly enabled via `camunda` dialect Closes nikku#36
Thanks, great contribution. Merged with minor adjustments (cf. 2e8da37). |
Which issue does this PR address?
Closes #36