Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/v3.24.0 #930

Merged
merged 84 commits into from
Apr 1, 2021
Merged

release/v3.24.0 #930

merged 84 commits into from
Apr 1, 2021

Conversation

peaBerberian
Copy link
Collaborator

@peaBerberian peaBerberian commented Mar 24, 2021

Status: Everything is ready, only thing left is testing.

For now scheduled for 2021-04-01 (but could be sooner or later).

Changelog

Features

Bug fixes

Other improvements

@peaBerberian peaBerberian added work-in-progress This Pull Request or issue is not finished yet release Pull Request for a release branch that is being tested labels Mar 24, 2021
Previous "production" value emitted warnings I think because the `mode`
webpack property was set to development.

I did not take the time to dive all the consequences but this is not too
bas as we're only speaking about the demo page.
peaBerberian and others added 21 commits March 31, 2021 15:52
…ot encountered

We had a bug in our implementation of the `singleLicensePer` API (not
yet released, hopefully), where we would not fallback from a quality
linked to a key id not found in the licence, only if that key id was the
first encountered.

This is because the check we (I) added to do that only did it on
subsequent key ids, not the first one that triggered the
license-fetching process.

I tried to add a fix but it is not as simple as it looks, because if
we're doing that in a `singleLicensePer`: "content"` mode, why not
always (as it would make sense to always fallback when the wanted key id
is not found in the corresponding license).

However I prefer not to do that due to both not break the API and the
possible compatibilities issues as explained in the code.

So I was left doing it only if `singleLicensePer` was not set to the
default value, and putting that code in `eme_manager.ts` instead of
where I would have preferred to put it, initially, in
`check_key_statuses.ts`.
…ingleLicense

DRM: In a singleLicensePer content mode, blacklist the first kid if not encountered
Skip parsing EMSG when version is different from 0
…ions

This method was only called by the `TrackChoiceManager` and a recent fix
ultimately led to the `NO_PLAYABLE_REPRESENTATIONS` not being thrown
anymore, as the `TrackChoiceManager` would just ignore tracks for which
all Representations are marked as not decipherable.

This could make sense, but I prefer to postpone such behavior change for
a future release.

This commit re-set the old behavior by just checking the codec support
through the `isSupported` property.
manifest: Rename Period.getPlayableAdaptations to getSupportedAdaptations
…o 15 to improve compatibility, even more now that license with multiple keys are properly handled
…g-v0

Do not cancel emsg parsing when an emsg whose version is not 0 has been encountered
@peaBerberian peaBerberian merged commit 6f97e56 into master Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Pull Request for a release branch that is being tested work-in-progress This Pull Request or issue is not finished yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants