-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release/v3.24.0 #930
Merged
Merged
release/v3.24.0 #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5d0980d.
Misc/revert tizen specific branch
Previous "production" value emitted warnings I think because the `mode` webpack property was set to development. I did not take the time to dive all the consequences but this is not too bas as we're only speaking about the demo page.
d3c568e
to
2aed98f
Compare
…ot encountered We had a bug in our implementation of the `singleLicensePer` API (not yet released, hopefully), where we would not fallback from a quality linked to a key id not found in the licence, only if that key id was the first encountered. This is because the check we (I) added to do that only did it on subsequent key ids, not the first one that triggered the license-fetching process. I tried to add a fix but it is not as simple as it looks, because if we're doing that in a `singleLicensePer`: "content"` mode, why not always (as it would make sense to always fallback when the wanted key id is not found in the corresponding license). However I prefer not to do that due to both not break the API and the possible compatibilities issues as explained in the code. So I was left doing it only if `singleLicensePer` was not set to the default value, and putting that code in `eme_manager.ts` instead of where I would have preferred to put it, initially, in `check_key_statuses.ts`.
…it comes synchronously
…ingleLicense DRM: In a singleLicensePer content mode, blacklist the first kid if not encountered
Skip parsing EMSG when version is different from 0
…ions This method was only called by the `TrackChoiceManager` and a recent fix ultimately led to the `NO_PLAYABLE_REPRESENTATIONS` not being thrown anymore, as the `TrackChoiceManager` would just ignore tracks for which all Representations are marked as not decipherable. This could make sense, but I prefer to postpone such behavior change for a future release. This commit re-set the old behavior by just checking the codec support through the `isSupported` property.
manifest: Rename Period.getPlayableAdaptations to getSupportedAdaptations
…o 15 to improve compatibility, even more now that license with multiple keys are properly handled
… 0 has been encountered
…g-v0 Do not cancel emsg parsing when an emsg whose version is not 0 has been encountered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release
Pull Request for a release branch that is being tested
work-in-progress
This Pull Request or issue is not finished yet
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status: Everything is ready, only thing left is testing.
For now scheduled for 2021-04-01 (but could be sooner or later).
Changelog
Features
inbandEvent
event for when an event is encountered in a media segment [Add EMSG support #892]singleLicensePer
keySystems
option to be able to signal in advance that the current content has a single license, even if it has multiple encryption keys [Multiple keys per license implementation #863, Single license per content implementation #904]keySystems[].licenseStorage.disableRetroCompatibility
boolean to unlock optimizations when compatibility with EME sessions persisted in older RxPlayer versions is not important [Only use concerned encryption systemId when found in the Manifest #919]Bug fixes
maxBufferAhead
is set, avoid removing the initially loaded data if done before the initial seek could be performed [Add the clock's wantedTimeOffest to the BufferGarbageCollector's #907]<Accessibility>
tags for a single AdaptationSet [Consider multiple accessibility descriptors #903]getStatusForHDCP
method from the experimentalMediaCapabilitiesProber
tool [DetectionHDCP can break cause of a miss interpreted error handling #927]Other improvements
manifestUpdateUrl
to request directly the right URL on next update. [Update manifest update URL at manifest partial refresh #929]serverCertificate
is given by calling thesetServerCertificate
API earlier [drm: perform setServerCertificate before init data has been received #895]audioDescription
tracks [Consider multiple accessibility descriptors #903]keyStatuses
updates [eme: wait at most 100ms after a session is loaded to check on its keyStatuses #928]