Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cinder OpenStackApplication #263

Merged
merged 4 commits into from
Mar 4, 2024
Merged

Add Cinder OpenStackApplication #263

merged 4 commits into from
Mar 4, 2024

Conversation

rgildein
Copy link
Contributor

@rgildein rgildein commented Feb 27, 2024 •
edited
Loading

Draft PR, based on #264

@rgildein rgildein added the bug Something isn't working label Feb 27, 2024
@rgildein rgildein self-assigned this Feb 27, 2024
@rgildein rgildein requested review from a team, Pjack, aieri, agileshaw and jneo8 February 27, 2024 17:33
aieri
aieri reviewed Feb 28, 2024
View reviewed changes
cou/apps/base.py Outdated Show resolved Hide resolved
tests/unit/apps/test_core.py Outdated Show resolved Hide resolved
tests/unit/apps/test_core.py Show resolved Hide resolved
cou/apps/core.py Show resolved Hide resolved
@rgildein rgildein marked this pull request as draft February 28, 2024 10:27
@rgildein rgildein changed the title Improve 'action-managed-upgrade' config handling Add Cinder OpenStackApplication Feb 28, 2024
@rgildein
fix unittests
7a7880a
@rgildein
Add units upgrade steps to the base OS app
654098f 
Add _get_units_upgrade_steps and use it for cinder and nova-compute.
@rgildein rgildein force-pushed the bug/BSENG-2087/add-cinder-app branch from 79c6ab0 to 654098f Compare February 29, 2024 16:17
@rgildein rgildein marked this pull request as ready for review February 29, 2024 16:26
gabrielcocenza
gabrielcocenza reviewed Feb 29, 2024
View reviewed changes
Copy link
Member

@gabrielcocenza gabrielcocenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM. I think there is no need to create a cinder class so far

cou/apps/base.py Outdated Show resolved Hide resolved
cou/apps/core.py Outdated Show resolved Hide resolved
cou/apps/core.py Outdated Show resolved Hide resolved
agileshaw
agileshaw reviewed Feb 29, 2024
View reviewed changes
Copy link
Contributor

@agileshaw agileshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. I'm +1 on only adding a Cinder application class when it is really necessary. This PR can just focus on unit-by-unit upgrade

@rgildein rgildein merged commit 62c2d2f into canonical:dev/data-plane Mar 4, 2024
4 checks passed
@rgildein rgildein deleted the bug/BSENG-2087/add-cinder-app branch March 4, 2024 19:58
This was referenced Mar 5, 2024
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aieri aieri aieri approved these changes

@gabrielcocenza gabrielcocenza gabrielcocenza approved these changes

@Pjack Pjack Awaiting requested review from Pjack

@jneo8 jneo8 Awaiting requested review from jneo8

@agileshaw agileshaw Awaiting requested review from agileshaw

Assignees

@rgildein rgildein

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rgildein @aieri @agileshaw @gabrielcocenza