Improve 'action-managed-upgrade' config handling #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge logic of `_get_disable_action_managed_step` and `_get_enable_action_managed_step` to single fucntion and fix not calling it if config option does not exist.
rgildein
added a commit
to rgildein/charmed-openstack-upgrader
that referenced
this pull request
Mar 19, 2024
These changes are result of [1] and [2]. --- [1]: canonical#231 [2]: canonical#264
rgildein
added a commit
that referenced
this pull request
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge logic of
_get_disable_action_managed_stepand_get_enable_action_managed_stepto single function and fix not calling it if config option does not exist.Previous we return the step to change 'action-managed-upgrade' even if option does not exist and we want
to enable it.