Start the conversion to Typescript #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is quite impressive! I haven't noticed this PR before. |
…rst component to use a connected component
When we switched getTimeObj to return strings, our sketchy zero check started to fail. Luckily our tests caught it!
I guess React does not like it when these are strings
This includes bringing the previous index.d.ts types into our Typescript code base.
(No idea why this works. We still need to actually supply the types!)
captbaritone
changed the title
|
#YOLO gonna merge this. We'll see what I broke. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only real blocker here is figuring out how to handle the move from ESLint to TSLint.
Update: I think this is ready to start doing some manual testing and then merge.