Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Ability to serialize state #656

Closed
wants to merge 1 commit into from
Closed

[WIP] Ability to serialize state #656

wants to merge 1 commit into from

Conversation

captbaritone
Copy link
Owner

@captbaritone captbaritone commented Sep 11, 2018

Just the very first groundwork for #654.

My thoughts so far:

  1. Rather than serializing the Redux sate as is, we should explicitly add the stuff we want to serialize and handle serializing/deserializing it manually.
  2. This will be so much easier once we have Typescript.
  3. We must be sure we can handle old serialized values.
  4. Users should construct a new Webamp instance and then manually restore state as a second step, rather than being able to construct a new instance from a serialized state.

@captbaritone
Copy link
Owner Author

captbaritone commented Sep 11, 2018

Probably worth waiting for Typescript support: #657.

@captbaritone
Copy link
Owner Author

Replaced by #658

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant