-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore position fixed #669
Conversation
|
@1j01 Very good point. Hmm. Perhaps we return the the drawing board. |
It's a shame the Wait, this approach may be salvageable yet! #webamp {
transform: translate(0, 0);
} From this answer, and also mentioned here (btw, test code: |
Once again, @1j01 brilliant idea. I got it working and started testing in browsers, only to find that it does not work in Firefox. In firefox, when you resize the browser window, the Webamp windows still end up expanding the scroll size of the window making it impossible to measure the natural size of the window. I went ahead and pushed my, failing, changes onto this branch so others could try it out while I think about other things to try. |
This ensures that their position does not influence the size of the window. Before the scroll size of the browser window was expanding to contain our webamp windows, which meant we could never measure the natural size of the window to position ourselves within it. Thanks to @1j01 for the idea to try `position: fixed;`
This allows the individual windows to be positon: fixed and still scroll with the window.
fc26d33
to
0049b11
Compare
I've rebased this PR on top of master, which includes a separate PR that unververted serialization. Now this PR is just the attempt at using position fixed for windows, so I've renamed it. I don't think this approach will work, so I'll close it for now, but maybe we can use some of the ideas here to find a different solution. |
I reverted #658 because it broke a few things:
Take a look at the last three commits to see the fixes for these issues.
Big thanks to @1j01 for the idea to try using
position: fixed
for the windows. 👏