Serialize to indexdb #658

captbaritone · 2018-09-19T00:15:37Z

First stab at serializing state!

captbaritone · 2018-09-19T06:33:32Z

I think all the right stuff is getting serialized now, but there are a few problems:

When Winamp mounts, it tries to center itself, so the positioning data can get overwritten.
We need to make sure that we respect the bounds of the current window size when reloading. Otherwise it's possible that we could serialize state in a very large window, and then reload in a very small window and have the Winamp windows be rendered all, or mostly, off screen.
Serializing state where all the windows are closed is... bad. Basically makes the entire domain broken for the user forever since you can't really recover.

On that note, here's a link to this PR's build with the clearState flag set: https://deploy-preview-658--ecstatic-poincare-fe4c13.netlify.com/?clearState=1

Open that if you end up with bad serialized state.

1j01 · 2018-09-19T07:50:10Z

Going back and forth between /?clearState=1 and /, I found sometimes it moves the windows collectively down and to the right significantly (when at /), without the user having moved the windows.

Edit: and going back and forth between something other than ?clearState=1 so it doesn't clear it, or refreshing instead, it can get even further to the bottom right. With diminishing returns. It'll move half as much each time, until it reaches the bottom right.

captbaritone · 2018-09-20T04:46:23Z

@1j01 Okay, the issue where it fails to keep the same position across reloads has now been resolved, I believe.

Next before we ship this we need to ensure there is no way to leave the user in a state where a window is outside of their window.

captbaritone · 2018-09-21T00:04:09Z

Update: You now need the useState=1 flag to opt into persisting state to IndexDB:

https://deploy-preview-658--ecstatic-poincare-fe4c13.netlify.com/?useState=1

…hen you construct it This also sets us up for being able to unbind things

This is particularly noticeable when state has been rehydrated from a serialized state.

… it, as a nice side benefit

… have saved

durasj

Pretty impressive stuff. Seems to work very well. I tried to do some quick smoke testing and created the #663. The only thing that doesn't seem to work is saving of the window positions. It used to work, but it seems to be broken now.

I've fixed the types and unified the code for the debounce and throttle. I'm not sure why are callbackArgs are defined in different scope, there doesn't seem to be any reason for that.

Btw. not sure if a mistake or not and I am really sorry for being "that guy", but it's an IndexedDB, not IndexDB. Just pointing it out to prevent some confusion in the future.

durasj · 2018-09-20T13:54:41Z

js/reducers/display.ts

+    skinGenLetterWidths,
+    skinColors,
+    skinPlaylistStyle
+  } = state;


I know it's not hip like the destructuring, but could this simply return something like { doubled: state.doubled, ... } to get rid of the repetition?

Yeah, both options kinda suck. Even without the destructuring you still need to write every property twice. My, dubious, rational was that this way I didn't have to write state. n times, but... I'm not sure how important that is.

durasj · 2018-09-30T20:33:23Z

js/mediaMiddleware.ts

@@ -129,7 +138,27 @@ export default (media: Media) => (store: MiddlewareStore) => {
      case SET_EQ_ON:
        media.enableEq();
        break;
+      case LOAD_SERIALIZED_STATE: {
+        // Set ALL THE THINGS!


durasj · 2018-09-30T20:48:40Z

js/reducers/windows.ts

+        genWindows: Utils.objectMap(state.genWindows, w => ({
+          ...w,
+          // Not sure why TypeScript can't figure this out for itself.
+          size: [0, 0] as [number, number]


This is probably caused by the "return type widening". Size type gets "widened" to number[]. Not sure how to work around this better than you did. Maybe it'll get eventually improved by the TS team. Seems there is a discussion for this.

Makes sense.

captbaritone · 2018-10-01T05:03:41Z

Thanks for the correction re indexeddb. I think I've fixed the position serialization issue. I'm going to ship this now, but the serialization will be off by default.

captbaritone requested a review from durasj September 19, 2018 00:15

captbaritone force-pushed the serialize-indexdb branch from c5dac30 to 05edf84 Compare September 20, 2018 04:44

captbaritone force-pushed the serialize-indexdb branch from 38c1b40 to 81eb38d Compare September 21, 2018 00:02

captbaritone force-pushed the serialize-indexdb branch from 4f686da to e595459 Compare September 23, 2018 04:08

This was referenced Sep 25, 2018

[WIP] Ability to serialize state #656

Closed

Provide a way to serialize/deserialize Webamp #654

Closed

captbaritone force-pushed the serialize-indexdb branch from e595459 to 4caa582 Compare September 27, 2018 14:58

captbaritone added 19 commits September 29, 2018 17:58

Serialize state to indexdb

d1b43d5

Add a flag to clear IndexDB state

4f57d26

Serialize media state, and apply equalizer state to on deserialize

6d4c44b

Persist window states (exept position)

b938d7c

Serialize window position as well

9d8ca3a

Don't exclude generic windows

be00f78

Move global file input out of NPM module

b42d5fb

Make hotkeys a function not a singleton class that has side effects w…

72875f3

…hen you construct it This also sets us up for being able to unbind things

Center windows correctly, even if the windows don't start at 0,0

15f4720

This is particularly noticeable when state has been rehydrated from a serialized state.

Don't center windows when restoring from serialized state

38f032b

Handle the case where positions might be an empty object to begin with

f266b60

Persist focus, and handle bad focus

9b5e2c1

Make state serialization opt-in (for now)

5fe64cd

Move centerWindowsIfNeeded to an action creatorThis forces us to type…

b543447

… it, as a nice side benefit

Add initial approach of recovering from bad window positions

464d424

Use namespaced Utils

0de5c2b

Use namespaced Utils for webamplazy

9524845

Begin tracking window size

ab5586c

Add back resetWindowLayout

71adca1

captbaritone added 8 commits September 29, 2018 18:00

Use browserSize from state. Make it non-optional

669df38

Export Box

a6b8d5a

Add types for WindowManager

e20ec66

Mark serialization methods priviate for now

7b92235

Clean up selectors file

d9c559e

Fix export

6c1d90a

Refactor how we manage window positions

78537ac

Split serialized state types into their own file

4d35337

captbaritone force-pushed the serialize-indexdb branch from 3579289 to 4d35337 Compare September 30, 2018 01:01

captbaritone and others added 3 commits September 30, 2018 00:19

Add many tests for serialization

282780a

Double check that the serialized state we generated equals the one we…

73ff4fd

… have saved

Refactor debounce and throttle

8f6ccbb

durasj reviewed Sep 30, 2018

View reviewed changes

captbaritone added 4 commits September 30, 2018 19:49

Add a few more generic assertions about serialized state

f3e0758

Fix spelling of IndexedDB

2e50263

Clean up comment

abad127

Don't re-center windows when loading from serialized state

9687954

captbaritone merged commit d778c03 into master Oct 1, 2018

This was referenced Oct 1, 2018

Revert "Serialize to indexdb" #664

Merged

Explore position fixed #669

Closed

Unrevert serialization and disable measuring #670

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Serialize to indexdb #658

Serialize to indexdb #658

captbaritone commented Sep 19, 2018

captbaritone commented Sep 19, 2018

1j01 commented Sep 19, 2018 •

edited

Loading

captbaritone commented Sep 20, 2018

captbaritone commented Sep 21, 2018

durasj left a comment •

edited

Loading

durasj Sep 20, 2018

captbaritone Oct 1, 2018

durasj Sep 30, 2018

durasj Sep 30, 2018 •

edited

Loading

captbaritone Oct 1, 2018

captbaritone commented Oct 1, 2018

Serialize to indexdb #658

Serialize to indexdb #658

Conversation

captbaritone commented Sep 19, 2018

captbaritone commented Sep 19, 2018

1j01 commented Sep 19, 2018 • edited Loading

captbaritone commented Sep 20, 2018

captbaritone commented Sep 21, 2018

durasj left a comment • edited Loading

Choose a reason for hiding this comment

durasj Sep 20, 2018

Choose a reason for hiding this comment

captbaritone Oct 1, 2018

Choose a reason for hiding this comment

durasj Sep 30, 2018

Choose a reason for hiding this comment

durasj Sep 30, 2018 • edited Loading

Choose a reason for hiding this comment

captbaritone Oct 1, 2018

Choose a reason for hiding this comment

captbaritone commented Oct 1, 2018

1j01 commented Sep 19, 2018 •

edited

Loading

durasj left a comment •

edited

Loading

durasj Sep 30, 2018 •

edited

Loading