Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui-lib): Bump up caraml ui-lib version #111

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

deadlycoconuts
Copy link
Contributor

@deadlycoconuts deadlycoconuts commented Jul 29, 2024

Context

This PR bumps up the version of caraml-dev/ui-lib so that we can import latest changes to it in other CaraML UI, such as MLP, Turing, Merlin, etc. (I forgot to have this bumped in PR #110 😑 I'll need to open another PR to update the version of caraml-dev/ui-lib used in the MLP UI after this PR has been merged).

@deadlycoconuts deadlycoconuts added the enhancement New feature or request label Jul 29, 2024
@deadlycoconuts deadlycoconuts self-assigned this Jul 29, 2024
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.14%. Comparing base (6c3023d) to head (6fc316d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #111   +/-   ##
=======================================
  Coverage   57.14%   57.14%           
=======================================
  Files          47       47           
  Lines        2443     2443           
=======================================
  Hits         1396     1396           
  Misses        851      851           
  Partials      196      196           
Flag Coverage Δ
api-test 57.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tiopramayudi tiopramayudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @deadlycoconuts

@deadlycoconuts
Copy link
Contributor Author

Thanks for the quick review! Merging this now! 🙏🏼

@deadlycoconuts deadlycoconuts merged commit 312a46a into caraml-dev:main Jul 29, 2024
10 checks passed
@deadlycoconuts deadlycoconuts deleted the update_caraml_ui_lib branch July 29, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants