Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): Update caraml-dev/ui-lib #112

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

deadlycoconuts
Copy link
Contributor

Context

Given the update to the ui-lib package in #111, this PR bumps up the version of the MLP UI, as well as its version of ui-lib used.

@deadlycoconuts deadlycoconuts added the enhancement New feature or request label Jul 29, 2024
@deadlycoconuts deadlycoconuts self-assigned this Jul 29, 2024
Copy link
Contributor

@tiopramayudi tiopramayudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks @deadlycoconuts

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.14%. Comparing base (312a46a) to head (dcba8ea).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #112   +/-   ##
=======================================
  Coverage   57.14%   57.14%           
=======================================
  Files          47       47           
  Lines        2443     2443           
=======================================
  Hits         1396     1396           
  Misses        851      851           
  Partials      196      196           
Flag Coverage Δ
api-test 57.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deadlycoconuts
Copy link
Contributor Author

Thanks for the quick review @tiopramayudi !

@deadlycoconuts deadlycoconuts merged commit cb2772d into caraml-dev:main Jul 29, 2024
10 checks passed
@deadlycoconuts deadlycoconuts deleted the update_mlp_ui branch July 29, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants