-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2023 data updates #121
2023 data updates #121
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ARB id take the form CAFR1234. There is one instance of CAFR-1234. Replace all instance of CAFR- with CAFR to address.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See details in comment below, but I think updating the data used in the tool will require more testing on the frontend (for example, we still need to add 2022 to the reporting periods filter).
.zenodo.json
Outdated
@@ -1,6 +1,6 @@ | |||
{ | |||
"title": "Compliance Users", | |||
"description": "In the California cap-and-trade program, polluting entities use carbon offsets for compliance. Who are they? This tool lets you search for an offset project, user, or facility, and see the linked results. Read more in our original blog post or checkout the GitHub repository. This tool was updated as of February 2023. ", | |||
"description": "In the California cap-and-trade program, polluting entities use carbon offsets for compliance. Who are they? This tool lets you search for an offset project, user, or facility, and see the linked results. Read more in our original blog post or checkout the GitHub repository. This tool was updated as of JAN-2024. ", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also update the date shown in the tool? Formatting as January 2024
would probably be better there.
compliance-users/components/layout.js
Line 36 in f26abf1
. This tool was updated as of February 2023. |
@@ -1,7 +1,7 @@ | |||
import create from 'zustand' | |||
|
|||
const url = | |||
'https://raw.githubusercontent.com/carbonplan/compliance-users/main/data/outputs/user_data_v2.0.json' | |||
'https://raw.githubusercontent.com/carbonplan/compliance-users/main/data/outputs/user_data_v3.0.json' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This request is failing on Vercel because the data is not yet on main
. Seems like there are two options for safely testing + rolling this out (and maybe you've already done step 1, in which case please ignore!):
- Temporarily update this to
https://raw.githubusercontent.com/carbonplan/compliance-users/1f4ef6ce890b44a24d811362a59d9960db58b0d3/data/outputs/user_data_v3.0.json
in order to test the tool and confirm that the data looks correct. - Merge the
data/
updates first before updating the tool (i.e. remove this update). Then in a follow-up PR, we could test the tool independently, update the user-facing date, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
implementing option 1!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking much better! Possible to add 2022
to the list of options here?
compliance-users/components/use-store.js
Lines 15 to 19 in f26abf1
reportingPeriods: { | |
'2013-2014': true, | |
'2015-2017': true, | |
'2018-2020': true, | |
2021: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once we update to use the real URL, I say we merge this 🚢
components/use-store.js
Outdated
@@ -1,7 +1,10 @@ | |||
import create from 'zustand' | |||
|
|||
// const url = | |||
// 'https://raw.githubusercontent.com/carbonplan/compliance-users/main/data/outputs/user_data_v3.0.json' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's restore this and merge!
This is an update with the new compliance data released in December 2023.
There are two loose ends I need to track down by emailing CARB: