Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2023 data updates #121

Merged
merged 10 commits into from
Jan 8, 2024
Merged

2023 data updates #121

merged 10 commits into from
Jan 8, 2024

Conversation

freyac
Copy link
Member

@freyac freyac commented Jan 5, 2024

This is an update with the new compliance data released in December 2023.

There are two loose ends I need to track down by emailing CARB:

  1. There's a facility id (104091) that appears in compliance data but not the contemporary facility data. From my last exchange with CARB, I think this is a result of the MRR data reflecting facility changes more quickly than the compliance data.
  2. There's a project id that appears in the compliance data, but not in the issuance data, which I think is just a typo (CAFR-6339-A).

Copy link

vercel bot commented Jan 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
compliance-users ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2024 8:00pm

@freyac freyac requested a review from badgley January 5, 2024 04:47
ARB id take the form CAFR1234. There is one instance of CAFR-1234.
Replace all instance of CAFR- with CAFR to address.
Copy link
Member

@katamartin katamartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See details in comment below, but I think updating the data used in the tool will require more testing on the frontend (for example, we still need to add 2022 to the reporting periods filter).

.zenodo.json Outdated
@@ -1,6 +1,6 @@
{
"title": "Compliance Users",
"description": "In the California cap-and-trade program, polluting entities use carbon offsets for compliance. Who are they? This tool lets you search for an offset project, user, or facility, and see the linked results. Read more in our original blog post or checkout the GitHub repository. This tool was updated as of February 2023. ",
"description": "In the California cap-and-trade program, polluting entities use carbon offsets for compliance. Who are they? This tool lets you search for an offset project, user, or facility, and see the linked results. Read more in our original blog post or checkout the GitHub repository. This tool was updated as of JAN-2024. ",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also update the date shown in the tool? Formatting as January 2024 would probably be better there.

. This tool was updated as of February 2023.

@@ -1,7 +1,7 @@
import create from 'zustand'

const url =
'https://raw.githubusercontent.com/carbonplan/compliance-users/main/data/outputs/user_data_v2.0.json'
'https://raw.githubusercontent.com/carbonplan/compliance-users/main/data/outputs/user_data_v3.0.json'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This request is failing on Vercel because the data is not yet on main. Seems like there are two options for safely testing + rolling this out (and maybe you've already done step 1, in which case please ignore!):

  1. Temporarily update this to https://raw.githubusercontent.com/carbonplan/compliance-users/1f4ef6ce890b44a24d811362a59d9960db58b0d3/data/outputs/user_data_v3.0.json in order to test the tool and confirm that the data looks correct.
  2. Merge the data/ updates first before updating the tool (i.e. remove this update). Then in a follow-up PR, we could test the tool independently, update the user-facing date, etc.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implementing option 1!

Copy link
Member

@katamartin katamartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking much better! Possible to add 2022 to the list of options here?

reportingPeriods: {
'2013-2014': true,
'2015-2017': true,
'2018-2020': true,
2021: true,

Copy link
Member

@katamartin katamartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we update to use the real URL, I say we merge this 🚢

@@ -1,7 +1,10 @@
import create from 'zustand'

// const url =
// 'https://raw.githubusercontent.com/carbonplan/compliance-users/main/data/outputs/user_data_v3.0.json'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's restore this and merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants