-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added new 2024 compliance data #126
Conversation
…liance data from Dec 2024
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@badgley, would you be willing to do a spot check QR/QC on the updated data? @katamartin, this branch does not yet include necessary changes to 'layout.js', '.zenodo.json', or the front-end (new compliance period to filters, changing pointer to v4 of the data). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quick skim — looks pretty good. i'll spot check data once its wired in vercel preview!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I'm following what the changes to zenodo.json
and layout.js
would be -- is there still more to do there?
But assuming the tool looks good with the temporary data pointer, it seems safe to merge with the ~broken pointer in this branch! (It looks like that what we did last year #121 (comment))
@@ -1,7 +1,7 @@ | |||
import create from 'zustand' | |||
|
|||
const url = | |||
'https://raw.githubusercontent.com/carbonplan/compliance-users/main/data/outputs/user_data_v3.0.json' | |||
'https://raw.githubusercontent.com/carbonplan/compliance-users/main/data/outputs/user_data_v4.0.json' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I temporarily pointed this at https://raw.githubusercontent.com/carbonplan/compliance-users/89408702a5c3c2e9b67fae954fb6b03acd4b4152/data/outputs/user_data_v4.0.json
and it looked good locally to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Kata! I had forgotten about that pattern. (cc @badgley for previewing the the new data on vercel)
I just changed the date in zenodo.js
and had already changed the dates in layout.js
, so I think we're good on that front.
sandbox
notebook