Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new 2024 compliance data #126

Merged
merged 7 commits into from
Dec 19, 2024
Merged

added new 2024 compliance data #126

merged 7 commits into from
Dec 19, 2024

Conversation

freyac
Copy link
Member

@freyac freyac commented Dec 12, 2024

  • added new compliance data that was published in Dec. 2024
  • cleaned up python scripts to better handle year-to-year variations in CARB excel file processing
  • fixed up the QR/QC sandbox notebook
  • updated documentation to reflect new data

Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
compliance-users ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 3:23pm

@freyac freyac requested review from badgley and katamartin December 12, 2024 18:44
@freyac
Copy link
Member Author

freyac commented Dec 12, 2024

@badgley, would you be willing to do a spot check QR/QC on the updated data?

@katamartin, this branch does not yet include necessary changes to 'layout.js', '.zenodo.json', or the front-end (new compliance period to filters, changing pointer to v4 of the data).

Copy link
Member

@badgley badgley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick skim — looks pretty good. i'll spot check data once its wired in vercel preview!

Copy link
Member

@katamartin katamartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I'm following what the changes to zenodo.json and layout.js would be -- is there still more to do there?

But assuming the tool looks good with the temporary data pointer, it seems safe to merge with the ~broken pointer in this branch! (It looks like that what we did last year #121 (comment))

@@ -1,7 +1,7 @@
import create from 'zustand'

const url =
'https://raw.githubusercontent.com/carbonplan/compliance-users/main/data/outputs/user_data_v3.0.json'
'https://raw.githubusercontent.com/carbonplan/compliance-users/main/data/outputs/user_data_v4.0.json'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I temporarily pointed this at https://raw.githubusercontent.com/carbonplan/compliance-users/89408702a5c3c2e9b67fae954fb6b03acd4b4152/data/outputs/user_data_v4.0.json and it looked good locally to me!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Kata! I had forgotten about that pattern. (cc @badgley for previewing the the new data on vercel)

I just changed the date in zenodo.js and had already changed the dates in layout.js, so I think we're good on that front.

@freyac freyac merged commit a6179bd into main Dec 19, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants