Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add connection management permissions #292

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Add connection management permissions #292

merged 1 commit into from
Dec 1, 2023

Conversation

rmstar
Copy link
Contributor

@rmstar rmstar commented Dec 1, 2023

No description provided.

@rmstar rmstar requested a review from dli357 December 1, 2023 18:39
dli357
dli357 reviewed Dec 1, 2023
View reviewed changes
Copy link
Contributor

@dli357 dli357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should create a MANAGE_SYSTEM_APP_ENTITIES RolePermission for the create/update/delete operations, and attach use to CREATE_PIPELINE and USE_WRANGLER, WDYT?

...n/java/io/cdap/cdap/security/authorization/ldap/role/permission/RolePermissionConverter.java Outdated Show resolved Hide resolved
...n/java/io/cdap/cdap/security/authorization/ldap/role/permission/RolePermissionConverter.java Outdated Show resolved Hide resolved
...n/java/io/cdap/cdap/security/authorization/ldap/role/permission/RolePermissionConverter.java Outdated Show resolved Hide resolved
@rmstar rmstar force-pushed the add_conn_mgmt_permissions branch from 8679bdd to 3063f27 Compare December 1, 2023 19:52
@rmstar rmstar force-pushed the add_conn_mgmt_permissions branch from 3063f27 to e30e0a4 Compare December 1, 2023 19:54
@rmstar
Copy link
Contributor Author

rmstar commented Dec 1, 2023

Maybe we should create a MANAGE_SYSTEM_APP_ENTITIES RolePermission for the create/update/delete operations, and attach use to CREATE_PIPELINE and USE_WRANGLER, WDYT?

Done

@rmstar rmstar merged commit 6d89359 into develop Dec 1, 2023
4 checks passed
@rmstar rmstar deleted the add_conn_mgmt_permissions branch December 1, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dli357 dli357 dli357 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmstar @dli357