Footer design audit #118
Merged
Footer design audit #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanWallace
requested changes
Mar 14, 2023
There was a problem hiding this comment.
Put some comments into the Footer CSS file.
Also have a couple questions:
- Do we need the underline on the sub footer links? They were originally styled that way to match the current style of the canada.ca footer
- Should the links in the contextual band and main footer also have the new focus style?
| @@ -145,24 +147,33 @@ | |||
|
|
|||
| @media screen and (min-width: 64em) { | |||
| display: inline-block; | |||
|
|
|||
| gcds-signature { | |||
| margin: 0 0 0 auto; | |||
There was a problem hiding this comment.
Can we turn this into a footer component token.
| text-decoration: underline; | ||
| text-underline-offset: 0.1em; | ||
| text-decoration-color: currentColor; | ||
| text-decoration-thickness: var(--gcds-border-width-sm); |
There was a problem hiding this comment.
Same comment as above
|
|
||
| &:hover { | ||
| color: var(--gcds-footer-sub-hover-text); | ||
| text-decoration-thickness: var(--gcds-border-width-md); |
There was a problem hiding this comment.
Same comment as above
| &:active { | ||
| color: var(--gcds-footer-sub-active-text); | ||
| background-color: var(--gcds-footer-sub-active-background); | ||
| border-radius: var(--gcds-border-radius-sm); |
There was a problem hiding this comment.
Same comment as above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request consists of the following work:
1) Updating the footer link styles to match the link styles on figma
2) Fixing alignment issues
3) Updating tokens