Footer update #96
Merged
Footer update #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tokens/components/footer/base.json
Outdated
| @@ -122,7 +122,7 @@ | |||
| }, | |||
| "hover": { | |||
| "text": { | |||
| "value": "{link.hover.value}", | |||
| "value": "{color.blue.900.value}", | |||
There was a problem hiding this comment.
Is there a reason you switched from the global link-hover token? They both seem to use blue.900
There was a problem hiding this comment.
woops, looks like I should have left it as link.hover
| @@ -169,7 +169,7 @@ | |||
| } | |||
| }, | |||
| "text": { | |||
| "value": "{link.default.value}", | |||
| "value": "{color.blue.800.value}", | |||
There was a problem hiding this comment.
Is there a reason we switched from the link.default token?
There was a problem hiding this comment.
this one, however, needs to change to 800 instead of 700. with the gray bg it doesn't meet AAA contrast standards and bumping it up to 800 fixes the contrast ratio.
Should I make a new token for this one or is it fine as is?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of the following work:
Updated some footer tokens for this PR