chore(deps): bump github.com/celestiaorg/nmt from 0.22.2 to 0.23.0 #131
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
the
dependencies
dependabot
bot
requested review from
cmwaters,
ninabarbakadze,
cristaloleg and
Wondertan
and removed request for
a team
rootulp
reviewed
Jan 21, 2025
go.mod
Outdated
| @@ -1,9 +1,10 @@ | |||
| module github.com/celestiaorg/go-square/v2 | |||
|
|
|||
| go 1.22.5 | |||
| toolchain go1.23.5 | |||
There was a problem hiding this comment.
why was this added? AFAIK nmt v0.23.0 doesn't use any new Go features from 1.23.x
There was a problem hiding this comment.
I think this is a problem with unsynced version of go and toolchain.
On CI we use 1.23 but go.mod specifies 1.22. That's why Go on CI specifies toolchain version. Either bump go to 1.23 or leave toolchain as it's.
BTW, not a big deal IMO and doesn't break anything.
There was a problem hiding this comment.
Fair enough, we can bump Go versions in a FLUP PR
dependabot
bot
force-pushed
the
dependabot/go_modules/github.com/celestiaorg/nmt-0.23.0
branch
from
5a7731d to
eef2ad3
Compare
dependabot
bot
force-pushed
the
dependabot/go_modules/github.com/celestiaorg/nmt-0.23.0
branch
from
eef2ad3 to
f8e3e23
Compare
rootulp
previously approved these changes
Feb 11, 2025
|
Nvm, looks like CI is failing. |
Bumps [github.com/celestiaorg/nmt](https://github.com/celestiaorg/nmt) from 0.22.2 to 0.23.0. - [Release notes](https://github.com/celestiaorg/nmt/releases) - [Commits](celestiaorg/nmt@v0.22.2...v0.23.0) --- updated-dependencies: - dependency-name: github.com/celestiaorg/nmt dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/go_modules/github.com/celestiaorg/nmt-0.23.0
branch
from
f8e3e23 to
b92cb2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps github.com/celestiaorg/nmt from 0.22.2 to 0.23.0.
Release notes
Sourced from github.com/celestiaorg/nmt's releases.
Commits
a336f12perf: do less allocs in hasher (#287)5b1b3d8fix: reduce calls to MinNamespace & MaxNamespace (#285)2fb6332ci: fix lint, markdown links, and build (#282)62ec215chore: fix ci linter failing (#276)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)