-
Notifications
You must be signed in to change notification settings - Fork 50
Conversation
cc @odeke-em |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @cuonglm!
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
=======================================
Coverage 85.68% 85.68%
=======================================
Files 6 6
Lines 468 468
=======================================
Hits 401 401
Misses 39 39
Partials 28 28 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm my understanding:
- The action
.github/workflows/fuzz_build.yml
is necessary to have a build which can then be included in oss-fuzz? And same withoss-fuzz-build.sh
? - the code under
fuzz/fuzz.go
is some very basic fuzzing to see if we panic on any random input/operation
Is that right?
Looks all good to me. Thanks so much!
No, See discussion in google/oss-fuzz#5631 (comment) for more details
Yes, exactly. |
While at it, also add oss fuzz build script for to prepare for adding to oss-fuzz later. Fixes celestiaorg#31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification!
LGTM
@liamsi @adlerjohn which email I should use as primary_contact for celestiaorg/smt? And which email you want to be in auto_ccs? See https://google.github.io/oss-fuzz/getting-started/new-project-guide/#primary for what primary_contact/auto_ccs mean. |
@cuonglm, @musalbas will setup an account / list [email protected] that will notify all relevant people. |
@liamsi I'd highly recommend separating out to say [email protected] lest the dev list get drowned out and folks shall get lots of other messages coming to dev :-) |
@liamsi Thanks! But to be able to see the dashboard, you need an individual Google Account, according to https://google.github.io/oss-fuzz/getting-started/new-project-guide/#primary So please list any email you want to be included. I'm currently listing only people from Orijtech https://github.com/google/oss-fuzz/pull/6134/files#diff-93b109d8f5b36384edc36042a809c0afdb84d4361312b1fb0f42cb46d66648e5R2 |
OK, for now please just use my email: [email protected] I guess it's easy to submit a PR oss-fuzz to change that later in case we create a dedicated account for this ([email protected] is also a list not an individual account afaik). |
Done. |
While at it, also add oss fuzz build script for to prepare for adding to
oss-fuzz later.
Fixes #31