Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cosmos-sdk project #5631

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Conversation

cuonglm
Copy link
Contributor

@cuonglm cuonglm commented Apr 19, 2021

No description provided.

@cuonglm cuonglm force-pushed the cuonglm/add-cosmos-sdk branch from 6f48bbe to fe16dae Compare April 19, 2021 03:47
@odeke-em
Copy link
Contributor

Thank you @cuonglm!

For reviewers, for context, the cosmos-sdk is used for a currency of a $4-5 Billion USD market cap as of April 18th 2021, it is heavily relied upon by an ecosystem securing at least $114 Billion USD as of April 18th 2021 It is relied upon by a whole bunch of projects too. Thank you!

@cuonglm cuonglm force-pushed the cuonglm/add-cosmos-sdk branch from d781567 to 1745e6c Compare April 19, 2021 10:22
Copy link
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for linking the issues! I see a lot more fuzzers in the branch, excited to see them added soon.

@asraa asraa merged commit 1336f9e into google:master Apr 19, 2021
@cuonglm
Copy link
Contributor Author

cuonglm commented Apr 19, 2021

@asraa We're going to make a script instead of adding more fuzzing by creating new PR in oss-fuzz repo, is it best practice?

I see a lot more fuzzers in the branch, excited to see them added soon.

Yes, there're more fuzzers in fuzz-packages branch, but we need to make some adjustment to make it works with compiler_go_fuzzer script.

@asraa
Copy link
Contributor

asraa commented Apr 19, 2021

@asraa We're going to make a script instead of adding more fuzzing by creating new PR in oss-fuzz repo, is it best practice?

If i understand correctly, then yes. Ideally, all the fuzzers live in cosmos main repo, and yes, you can reference the build script in your dir in build.sh

@cuonglm
Copy link
Contributor Author

cuonglm commented Apr 19, 2021

@asraa We're going to make a script instead of adding more fuzzing by creating new PR in oss-fuzz repo, is it best practice?

If i understand correctly, then yes. Ideally, all the fuzzers live in cosmos main repo, and yes, you can reference the build script in your dir in build.sh

Thanks FYI 👍 I added a PR for that #5638

@odeke-em odeke-em deleted the cuonglm/add-cosmos-sdk branch April 19, 2021 17:36
@cuonglm
Copy link
Contributor Author

cuonglm commented Apr 20, 2021

Hi @asraa, sorry for hijack you again. So I changed all cosmos-sdk current fuzzer to work with compile_go_fuzzer script in cosmos/cosmos-sdk@f551128

How can I know whether the change is good or bad (e.g, break oss-fuzz build or not)?

@asraa
Copy link
Contributor

asraa commented Apr 20, 2021

You can check builds here https://oss-fuzz-build-logs.storage.googleapis.com/index.html#cosmos-sdk that run daily

but since the build script lives in your repo you won't see the presubmit on a PR change (I think for that reason most projects have oss-fuzz specific build scripts living in oss-fuzz, but code living in their repo that may run in their CI as presubmit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants