Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS: ‘Could not connect to firebase’ error is shown for fraction of seconds on ‘Invitation code’ page while processing with invitation code. #3622

Closed
Lss-Ankit opened this issue Apr 28, 2020 · 6 comments · Fixed by #3650
Closed

iOS: ‘Could not connect to firebase’ error is shown for fraction of seconds on ‘Invitation code’ page while processing with invitation code. #3622

Lss-Ankit opened this issue Apr 28, 2020 · 6 comments · Fixed by #3650
Assignees
@jeanregisser
Labels
bug Something isn't working ios Priority: P2 Major qa wallet

Comments

@Lss-Ankit
Copy link

Frequency: 100%
iOS App version: iOS Testflight build : v1.7.1 (28)
Repro on iOS device: iPhone 11 Pro (13.3)

Repro Steps:

  1. Launch the app and Enter the phone number
  2. Tap on ‘Continue’ button and Add security pin
  3. Navigate to ‘Invitation Code’ page and Enter invitation code
  4. Make sure process gets start and Observe while processing

Current Behavior: ‘Could not connect to firebase’ error is shown for fracation of seconds

Expected Behavior: ‘Could not connect to firebase’ error should be not be shown

Investigation:

  1. Issue does not reproduce in Android
  2. Randomly, Same error is shown when user navigating into the app

Attachment: iOS_Couldn’t connect to Firebase error is shown (Observe the issue between 0:32 to 0:37 secs)
@Lss-Ankit Lss-Ankit changed the title iOS: ‘Could not connect to firebase’ error is shown for fraction of seconds on ‘Invitation code’ page while processing with invitation code iOS: ‘Could not connect to firebase’ error is shown for fraction of seconds on ‘Invitation code’ page while processing with invitation code. Apr 28, 2020
@jeanregisser jeanregisser self-assigned this Apr 29, 2020
@jeanregisser jeanregisser mentioned this issue Apr 29, 2020
Merged
@mergify mergify bot closed this as completed in #3650 Apr 29, 2020
mergify bot pushed a commit that referenced this issue Apr 29, 2020
@jeanregisser
[Wallet] Fix Firebase regressions on iOS
96eadd6 
### Description

Follow up PR to #3320

This PR fixes crashes on iOS related to the database module.
I had already patched those for `react-native-firebase` v5 (see invertase/react-native-firebase#2734).
Turns out a similar patch is still needed for v6. I will submit a PR upstream too for v6.

Also fixed broken push registration on iOS. There was a new call needed with v6.
I upgraded `react-native-firebase` to v6.7.1 since it changed push registration too, this way we're already on top again (but for how long? 😉).

These issues are reproducible only when using a real device.

### Tested

- App doesn't crash anymore on iOS in release mode.
- Push registration works

I could NOT test push being received successfully as `notification-service` currently has a similar issue as `blockchain-api` did a couple of days ago (fixed in #3583).

### Related issues

- Fixes #3622
- Fixes #3623

### Backwards compatibility

Yes.
@Lss-Ankit
Copy link
Author

Hi @jeanregisser , @annakaz @nityas Verified with Android Valora Mainnet build v1.0.0 (16) and found that
iOS: ‘Could not connect to firebase’ error is shown for fraction of seconds on home screen after sign up with new account and sign in with account key.

Note: Issue does not repro on IOS test flight build v1.0.0 (15)
Attachment:

Android_FirebaseIssue

@Lss-Ankit Lss-Ankit reopened this Aug 27, 2020
@jeanregisser
Copy link
Contributor

jeanregisser commented Aug 28, 2020 •
edited
Loading

Thanks, could you try with iOS build v1.0.1 (17) when you get a chance?

@nityas nityas added Priority: P2 Major and removed Priority: P3 Minor labels Aug 28, 2020
@annakaz
Copy link
Contributor

annakaz commented Aug 28, 2020

It seems like this is happening intermittently throughout the app, unrelated to invite code redemption. @Lss-Ankit can you confirm whether this consistently happens during invite redemption, or only sometimes?

@Lss-Ankit
Copy link
Author

@annakaz , @jeanregisser Issue is reproduced when user navigate to Home tab after sign up with new account or sign in with existing account using account key. also some time i have observed issue after cold launch the app.

currently issue is not observed during invite redemption.

However i have verified issue again on Android Valora Mainnet build v1.0.0 (16), Test Flight build Valora app build v1.0.1 (17) and not observe error message after sign up / sign in or cold launch the app.
Verified on: Google Pixel Xl (8.1) , iPhone 7+ (13.3.1)

hence closing ticket.
Thanks!

@Lss-Ankit
Copy link
Author

Lss-Ankit commented Oct 29, 2020 •
edited
Loading

Hi @annakaz , @jeanregisser I have verified this issue using latest Android Internal Build v1.30(1004294316) on lower end devices and observed that issue is still reproduced.
User get 'Could not connect to Firebase' error massage when user login with new account by tapping on 'Create new account' option after tapping on 'Don't have an invite code' button.
Repro on devices: Samsung Galaxy A5(5.0.2) ,
Frequency: 80%
Attachment: CouldNotConnectToFirebase.mp4

@Lss-Ankit Lss-Ankit reopened this Oct 29, 2020
@nityas nityas closed this as completed Dec 14, 2020
@ValoraQA
Copy link

Hi @jeanregisser I have verified this issue using latest Android Internal Build v1.15.2 on lower end devices and and found issue is fixed so, we are closing this ticket.
Devices: Samsung Galaxy A5(5.0.2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeanregisser jeanregisser

Labels
bug Something isn't working ios Priority: P2 Major qa wallet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Wallet] Fix Firebase regressions on iOS celo-org/celo-monorepo
5 participants
@jeanregisser @nityas @annakaz @Lss-Ankit @ValoraQA