[Wallet] Fix Firebase regressions on iOS #3650
Merged
+161
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…module This is similar to the patch done for react-native-firebase v5 See invertase/react-native-firebase#2734
Codecov Report
@@ Coverage Diff @@
## master #3650 +/- ##
==========================================
- Coverage 75.53% 75.53% -0.01%
==========================================
Files 619 619
Lines 15789 15791 +2
Branches 1724 1793 +69
==========================================
+ Hits 11926 11927 +1
+ Misses 3491 3488 -3
- Partials 372 376 +4
Continue to review full report at Codecov.
|
jeanregisser
commented
Apr 29, 2020
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "react-native": { | |||
| "messaging_ios_auto_register_for_remote_messages": false | |||
There was a problem hiding this comment.
This is because we don't want the system popup with asking for push permissions right when the user runs the app for the first time.
Push permission is asked later on when we create the user account.
jmrossy
approved these changes
Apr 29, 2020
jeanregisser
added a commit
that referenced
this pull request
Jul 23, 2020
This broke in #3650 because yield call return types are not inferred yet :/
mergify bot
pushed a commit
that referenced
this pull request
Jul 23, 2020
### Description This broke in #3650 with the upgrade of `react-native-firebase` because `yield call(...)` return types are not inferred yet 😞 Looks like the device I used when I worked on #3650 was already authorised for push that's why I missed that 2nd regression 🤦 ### Tested Tested that push permission is being asked again on iOS. ### Backwards compatibility Yes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up PR to #3320
This PR fixes crashes on iOS related to the database module.
I had already patched those for
react-native-firebasev5 (see invertase/react-native-firebase#2734).Turns out a similar patch is still needed for v6. I will submit a PR upstream too for v6.
Also fixed broken push registration on iOS. There was a new call needed with v6.
I upgraded
react-native-firebaseto v6.7.1 since it changed push registration too, this way we're already on top again (but for how long? 😉).These issues are reproducible only when using a real device.
Tested
I could NOT test push being received successfully as
notification-servicecurrently has a similar issue asblockchain-apidid a couple of days ago (fixed in #3583).Related issues
Backwards compatibility
Yes.