-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added txpool family to geth apis. Sorted geth cmd options #1462
Merged
celo-ci-bot-user
merged 2 commits into
celo-org:master
from
jcortejoso:fix/enable_txpool_api
Oct 30, 2019
Merged
Added txpool family to geth apis. Sorted geth cmd options #1462
celo-ci-bot-user
merged 2 commits into
celo-org:master
from
jcortejoso:fix/enable_txpool_api
Oct 30, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently Blockscout Indexer shows this error due to the lack of this API:
|
Codecov Report
@@ Coverage Diff @@
## master #1462 +/- ##
=======================================
Coverage 73.74% 73.74%
=======================================
Files 277 277
Lines 7420 7420
Branches 660 660
=======================================
Hits 5472 5472
Misses 1836 1836
Partials 112 112
Continue to review full report at Codecov.
|
asaj
approved these changes
Oct 30, 2019
aaronmgdr
added a commit
that referenced
this pull request
Nov 2, 2019
* master: (62 commits) Fix e2e on CI (#1537) Allow a specified address to disable/enable the Exchange (#1467) Avoid re-encrypting key files with yarn keys:encrypt command (#1560) Support protocol hotfixing (#613) Point e2e tests back (#1562) Refactor to Accounts.sol (#1392) Add selectIssuers Transaction (#1327) [Wallet] Get React Native Hot Reloading Working (#1551) Unify to prefix messages for signing (#1473) [Wallet] Improve error handling around account creation and keystore ops (#1497) Add CI test for checking licenses and misc package.json cleanup (#1550) [Wallet] Implement SMS invite on iOS (#1541) CI: brings back to master (#1554) Validators: uses Ethereum address for proof of possession (#1494) Validate Attestation Requests (#1468) Rename hosted node references to forno (#1511) Bump rubyzip from 1.2.3 to 1.3.0 in /packages/mobile (#1508) Added txpool family to geth apis. Sorted geth cmd options (#1462) [Wallet] Fix yarn dev command for running android (#1534) [Wallet] iOS info plist changes and version bump (#1539) ... # Conflicts: # yarn.lock
This was referenced Aug 5, 2022
This was referenced Oct 6, 2022
This was referenced Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the api family
txpool
(doc) needed by Blockscout.Tested
The method works locally. Not tested yet deploying using helm
Other changes
Sorted the cmd options of the geth command to ease the changes between sections
Related issues
Backwards compatibility
The change should not affect compatibility in any way.