Fix e2e on CI #1537
Merged
Fix e2e on CI #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1537 +/- ##
========================================
Coverage 73.61% 73.61%
========================================
Files 277 277
Lines 7443 7443
Branches 956 662 -294
========================================
Hits 5479 5479
Misses 1852 1852
Partials 112 112
Continue to review full report at Codecov.
|
…norepo into martinvol/small_e2e_fix
…norepo into martinvol/small_e2e_fix
martinvol
force-pushed
the
martinvol/small_e2e_fix
branch
from
954aa10 to
c10929a
Compare
nategraf
reviewed
Oct 31, 2019
| @@ -202,8 +202,8 @@ jobs: | |||
| # echo "Cache found, just run post-script." | |||
| # yarn postinstall | |||
| # fi | |||
| yarn | |||
| yarn build | |||
| yarn || yarn | |||
There was a problem hiding this comment.
Is there any chance we can figure out why the yarn command is flaky? Retries will only get us so far and increase the time to CI reporting real failures. I understand if you don't have time now, but creating an issue with what you know and a TODO here pointing to that issue would be helpful.
There was a problem hiding this comment.
Oh, so are the failures because of wix/Detox#1723? if so a reference inline to this file would be good
There was a problem hiding this comment.
We do those retries in many places, for example here:
celo-monorepo/.circleci/config.yml
Line 93 in 8fb3ff5
It is because because sometimes npm has a latency problem and the whole build fails. The retry is only executed if the jobs fails. Also the build command, as it requires network resources it's not guaranteed it's 100% deterministic.
The problems related to detox is in Run test itself, and it has the inline reference indeed :)
jmrossy
approved these changes
Nov 1, 2019
martinvol
force-pushed
the
martinvol/small_e2e_fix
branch
from
d2042c1 to
228935e
Compare
martinvol
force-pushed
the
martinvol/small_e2e_fix
branch
from
228935e to
7c0e523
Compare
…norepo into martinvol/small_e2e_fix
martinvol
force-pushed
the
martinvol/small_e2e_fix
branch
from
7c0e523 to
5137d1d
Compare
aaronmgdr
added a commit
that referenced
this pull request
Nov 2, 2019
* master: (62 commits) Fix e2e on CI (#1537) Allow a specified address to disable/enable the Exchange (#1467) Avoid re-encrypting key files with yarn keys:encrypt command (#1560) Support protocol hotfixing (#613) Point e2e tests back (#1562) Refactor to Accounts.sol (#1392) Add selectIssuers Transaction (#1327) [Wallet] Get React Native Hot Reloading Working (#1551) Unify to prefix messages for signing (#1473) [Wallet] Improve error handling around account creation and keystore ops (#1497) Add CI test for checking licenses and misc package.json cleanup (#1550) [Wallet] Implement SMS invite on iOS (#1541) CI: brings back to master (#1554) Validators: uses Ethereum address for proof of possession (#1494) Validate Attestation Requests (#1468) Rename hosted node references to forno (#1511) Bump rubyzip from 1.2.3 to 1.3.0 in /packages/mobile (#1508) Added txpool family to geth apis. Sorted geth cmd options (#1462) [Wallet] Fix yarn dev command for running android (#1534) [Wallet] iOS info plist changes and version bump (#1539) ... # Conflicts: # yarn.lock
aaronmgdr
added a commit
that referenced
this pull request
Dec 5, 2019
* master: (73 commits) Fix Ethstats Image reference (#1577) EU Cookies Behavior Change (#1447) [verifier] Upgrade to RN 61 (#1572) [Wallet] Update link styles and Implement VerificationEducationScreen (#1565) [wallet] Added native phone picker (#1310) [Wallet] Set up new verification screen skeletons (#1563) Bump e2e test migrate numbers where needed (#1567) [Wallet] Create new carousel component (#1555) [Wallet] Protect Backup Key and Safeguards with PIN (#1556) Increase ganache gas limit (#1569) Re-work locked gold requirements for validators and groups (#1474) Fix e2e on CI (#1537) Allow a specified address to disable/enable the Exchange (#1467) Avoid re-encrypting key files with yarn keys:encrypt command (#1560) Support protocol hotfixing (#613) Point e2e tests back (#1562) Refactor to Accounts.sol (#1392) Add selectIssuers Transaction (#1327) [Wallet] Get React Native Hot Reloading Working (#1551) Unify to prefix messages for signing (#1473) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
yarn,yarn buildandyarn detox.Tested
itself.
Other changes
Deleted legacy scripts related to e2e.
Related issues
Backwards compatibility