Use correct phone placeholder depending on the country on joining Celo view #2061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pedro-vk
force-pushed
the
bugfix/#865-country-code-input-size
branch
from
97484bd to
defee69
Compare
jmrossy
reviewed
Dec 5, 2019
| @@ -49,6 +50,7 @@ export default class PhoneNumberInput extends React.Component<Props, State> { | |||
| phoneNumber: '', | |||
| // country data should be fetched before mounting to prevent a second render | |||
| countries: new Countries(this.props.lng), | |||
| inputPhonePlaceholder: this.props.inputPhonePlaceholder, | |||
There was a problem hiding this comment.
We should rename the prop, how about initialInputPhonePlaceholder?
There was a problem hiding this comment.
Sure, I'm going to change it
Pedro-vk
force-pushed
the
bugfix/#865-country-code-input-size
branch
3 times, most recently
from
73eafa8 to
60c0884
Compare
jmrossy
reviewed
Dec 5, 2019
packages/utils/src/phoneNumbers.ts
Outdated
| @@ -231,6 +231,34 @@ export function anonymizedPhone(phoneNumber: string) { | |||
| return phoneNumber.slice(0, -4) + 'XXXX' | |||
| } | |||
|
|
|||
| export function getExampleNumber( | |||
| regionCode: string, | |||
| showZero: boolean = true, | |||
There was a problem hiding this comment.
Suggest renaming to useOnlyZeroes
packages/utils/src/countries.ts
Outdated
| @@ -140,6 +146,10 @@ export class Countries { | |||
| const localizedCountry = { | |||
| names, | |||
| displayName: names[this.language], | |||
| countryPhonePlaceholder: { | |||
| national: getExampleNumber(country.countryCallingCodes[0]), | |||
| internation: getExampleNumber(country.countryCallingCodes[0], true, true), | |||
There was a problem hiding this comment.
Don't think we need the international version right? Let's not calculate one for each country. Keep in mind this re-runs each time the app opens.
Also, typo: internatio -> international
Pedro-vk
force-pushed
the
bugfix/#865-country-code-input-size
branch
3 times, most recently
from
eaeb7dd to
79e93c6
Compare
Codecov Report
@@ Coverage Diff @@
## master #2061 +/- ##
========================================
Coverage 74.81% 74.81%
========================================
Files 276 276
Lines 7766 7766
Branches 976 692 -284
========================================
Hits 5810 5810
Misses 1839 1839
Partials 117 117
Continue to review full report at Codecov.
|
Pedro-vk
force-pushed
the
bugfix/#865-country-code-input-size
branch
4 times, most recently
from
0d3433f to
bfd7f8d
Compare
Pedro-vk
force-pushed
the
bugfix/#865-country-code-input-size
branch
4 times, most recently
from
65c8884 to
5e367d5
Compare
jmrossy
approved these changes
Dec 12, 2019
Pedro-vk
force-pushed
the
bugfix/#865-country-code-input-size
branch
3 times, most recently
from
e5f6933 to
a8d8b00
Compare
Pedro-vk
force-pushed
the
bugfix/#865-country-code-input-size
branch
5 times, most recently
from
0ecf6dc to
a8430d0
Compare
Pedro-vk
force-pushed
the
bugfix/#865-country-code-input-size
branch
from
a8430d0 to
c9758d8
Compare
aaronmgdr
added a commit
that referenced
this pull request
Dec 16, 2019
* master: (40 commits) Add utils as a dep (#2252) [Wallet] Create run_app.sh script to facilitate app development (#2186) [Wallet] Fix persisted data loss on iOS (#2249) adds Testing TSX /react on the web (#2229) Update running-a-validator.md (#2259) Add ts-ignore (#2254) Revert "Revert "Upgrade TS version (#2196)" (#2251)" (#2255) Force same bignumber version (#2256) Fix missing Text on website (#2237) Revert "Upgrade TS version (#2196)" (#2251) [Wallet] Refer to Celo Lite as "Data Saver" mode (#2232) Fix using requester instead of requestee at Outgoing notifications (#2240) Use correct phone placeholder depending on the country on joining Celo view (#2061) Update Attestation Bot Docker Image (#2231) Baklava phase 1.1 .env file (#2226) [Docs] Fix typo (#2225) Upgrade Dependencies and get react hooks working (#2203) Update attestation service docker images (#2202) Updates TME docker images (#2200) Remove walletkit from celotool transactions commands (#2206) ... # Conflicts: # packages/web/package.json
aaronmgdr
added a commit
that referenced
this pull request
Dec 16, 2019
* master: Add utils as a dep (#2252) [Wallet] Create run_app.sh script to facilitate app development (#2186) [Wallet] Fix persisted data loss on iOS (#2249) adds Testing TSX /react on the web (#2229) Update running-a-validator.md (#2259) Add ts-ignore (#2254) Revert "Revert "Upgrade TS version (#2196)" (#2251)" (#2255) Force same bignumber version (#2256) Fix missing Text on website (#2237) Revert "Upgrade TS version (#2196)" (#2251) [Wallet] Refer to Celo Lite as "Data Saver" mode (#2232) Fix using requester instead of requestee at Outgoing notifications (#2240) Use correct phone placeholder depending on the country on joining Celo view (#2061) Update Attestation Bot Docker Image (#2231) Baklava phase 1.1 .env file (#2226) [Docs] Fix typo (#2225) Upgrade Dependencies and get react hooks working (#2203) Update attestation service docker images (#2202) Updates TME docker images (#2200) Remove walletkit from celotool transactions commands (#2206)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use correct phone placeholder depending on the country on joining Celo view
Tested
Tested on Android phone
Related issues