[Wallet] Refer to Celo Lite as "Data Saver" mode #2232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2232 +/- ##
==========================================
- Coverage 74.82% 74.81% -0.02%
==========================================
Files 276 276
Lines 7771 7766 -5
Branches 694 692 -2
==========================================
- Hits 5815 5810 -5
Misses 1839 1839
Partials 117 117
Continue to review full report at Codecov.
|
aaronmgdr
added a commit
that referenced
this pull request
Dec 16, 2019
* master: (40 commits) Add utils as a dep (#2252) [Wallet] Create run_app.sh script to facilitate app development (#2186) [Wallet] Fix persisted data loss on iOS (#2249) adds Testing TSX /react on the web (#2229) Update running-a-validator.md (#2259) Add ts-ignore (#2254) Revert "Revert "Upgrade TS version (#2196)" (#2251)" (#2255) Force same bignumber version (#2256) Fix missing Text on website (#2237) Revert "Upgrade TS version (#2196)" (#2251) [Wallet] Refer to Celo Lite as "Data Saver" mode (#2232) Fix using requester instead of requestee at Outgoing notifications (#2240) Use correct phone placeholder depending on the country on joining Celo view (#2061) Update Attestation Bot Docker Image (#2231) Baklava phase 1.1 .env file (#2226) [Docs] Fix typo (#2225) Upgrade Dependencies and get react hooks working (#2203) Update attestation service docker images (#2202) Updates TME docker images (#2200) Remove walletkit from celotool transactions commands (#2206) ... # Conflicts: # packages/web/package.json
aaronmgdr
added a commit
that referenced
this pull request
Dec 16, 2019
* master: Add utils as a dep (#2252) [Wallet] Create run_app.sh script to facilitate app development (#2186) [Wallet] Fix persisted data loss on iOS (#2249) adds Testing TSX /react on the web (#2229) Update running-a-validator.md (#2259) Add ts-ignore (#2254) Revert "Revert "Upgrade TS version (#2196)" (#2251)" (#2255) Force same bignumber version (#2256) Fix missing Text on website (#2237) Revert "Upgrade TS version (#2196)" (#2251) [Wallet] Refer to Celo Lite as "Data Saver" mode (#2232) Fix using requester instead of requestee at Outgoing notifications (#2240) Use correct phone placeholder depending on the country on joining Celo view (#2061) Update Attestation Bot Docker Image (#2231) Baklava phase 1.1 .env file (#2226) [Docs] Fix typo (#2225) Upgrade Dependencies and get react hooks working (#2203) Update attestation service docker images (#2202) Updates TME docker images (#2200) Remove walletkit from celotool transactions commands (#2206)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is internal confusion as to whether Celo Lite refers to the ultralight client (it does not), or whether it is related to the Light Wallet (it is not).
This replaces the term Celo Lite with "Data Saver" (the user-facing term) == zeroSync (developer-facing term which makes it clear we're not syncing block headers) for using the app with a hosted forno node. Note that forno refers to the hosted node service.
Tested
Ran tests and asked a few people if this was less confusing
Related issues
Backwards compatibility
Yes, this just changes the wording on the settings page