-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Substitute mock-accountant macro by a mock builder pallet #1652
Merged
Merged
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
083d77f
Replace mock-accountant macro with mock builder pallet and Rate by
lemunozm 3f6ef81
remove unused test-utils mocks
lemunozm 851d435
add warn
lemunozm 03a053e
update mock-builder dependency
lemunozm 6aeed9f
improve mock configuration
lemunozm e78c0c3
modify hardcoded values in tests due rounding issues
lemunozm f427d38
modify event index
lemunozm 3487a98
fix benchmarking tests
lemunozm 46076b6
remove Default restriction for pool mocks
lemunozm 6d81794
Merge remote-tracking branch 'origin/main' into remove-mock-accountant
lemunozm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The application of foss3/runtime-pallet-library#16, @wischli
Basically the pallet implements
deposit()
andwithdraw()
methods from two different traits. So we need to addmock_<trait>_method()
to one of thesedeposit()/withdraw()
to differentiate from the othersIn those cases, the
T::AccountId
used as generic forInvestmentAccountant
was wrongly internally coded.