Add support for Substrate Network on Key load #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 461cf42.
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
==========================================
- Coverage 60.53% 60.50% -0.03%
==========================================
Files 88 88
Lines 3613 3618 +5
==========================================
+ Hits 2187 2189 +2
- Misses 1072 1074 +2
- Partials 354 355 +1
Continue to review full report at Codecov.
|
philipstanislaus
approved these changes
Jul 17, 2020
signature/signature.go
Outdated
| @@ -165,12 +173,13 @@ func Verify(data []byte, sig []byte, privateKeyURI string) (bool, error) { | |||
| // LoadKeyringPairFromEnv looks up whether the env variable TEST_PRIV_KEY is set and is not empty and tries to use its | |||
| // content as a private phrase, seed or URI to derive a key ring pair. Panics if the private phrase, seed or URI is | |||
| // not valid or the keyring pair cannot be derived | |||
| func LoadKeyringPairFromEnv() (kp KeyringPair, ok bool) { | |||
| // Can take a Network property, leave empty for default | |||
| func LoadKeyringPairFromEnv(network string) (kp KeyringPair, ok bool) { | |||
There was a problem hiding this comment.
What about loading the network also from an env variable here?
There was a problem hiding this comment.
Yep, I can do that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.