Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ExtrinsicSignatureV5 #68

Merged
merged 5 commits into from
Apr 7, 2020
Merged

Add ExtrinsicSignatureV5 #68

merged 5 commits into from
Apr 7, 2020

Conversation

ansermino
Copy link
Contributor

@ansermino ansermino commented Apr 7, 2020 •
edited
Loading

This mitigates the issue with the Address type needing to be configurable by just using it in place of Address.

This should resolve any present issue of errors like this:

Verification Error: Execution(ApiError("Could not convert parameter tx between node and runtime: No such variant in enum MultiSignature"))

Note: This error can be fixed in the UI by adding Address: AccountId to the custom type declarations.

mikiquantum
mikiquantum approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@mikiquantum mikiquantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @ansermino !

@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #68 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
- Coverage   60.58%   60.57%   -0.02%     
==========================================
  Files          87       87              
  Lines        3506     3505       -1     
==========================================
- Hits         2124     2123       -1     
  Misses       1034     1034              
  Partials      348      348
Impacted Files Coverage Δ
rpc/state/get_storage.go 64.28% <ø> (-1.24%) ⬇️
signature/signature.go 63.49% <100.00%> (ø)
types/extrinsic.go 51.03% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8080cdb...39c0a44. Read the comment docs.

philipstanislaus
philipstanislaus approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@philipstanislaus philipstanislaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @ansermino

@philipstanislaus philipstanislaus merged commit 461cf42 into centrifuge:master Apr 7, 2020
@philipstanislaus philipstanislaus mentioned this pull request Apr 7, 2020
Closed
mikiquantum added a commit to mikiquantum/go-substrate-rpc-client that referenced this pull request Apr 8, 2020
@mikiquantum
Revert "Add ExtrinsicSignatureV5 (centrifuge#68)"
0614f26 
This reverts commit 461cf42.
mikiquantum added a commit that referenced this pull request Apr 8, 2020
@mikiquantum
Revert "Add ExtrinsicSignatureV5 (#68)" (#70)
6f0547f 
This reverts commit 461cf42.
mikiquantum added a commit that referenced this pull request Jul 14, 2020
@mikiquantum
Increase precision of UCompact type to scale max (#85)
53c1093 
* Revert "Add ExtrinsicSignatureV5 (#68)"

This reverts commit 461cf42.

* Increase precision ucompact to max

* remove test codee

* Move to scale and make Reverse function public

* Clean event record SomeOffline test

* imports

* review comments
mikiquantum added a commit that referenced this pull request Jul 16, 2020
@mikiquantum
Fix/events (#86)
6c55974 
* Revert "Add ExtrinsicSignatureV5 (#68)"

This reverts commit 461cf42.

* Events fix

* fixes

* Fix DispatchError

* Fix tests
mikiquantum added a commit that referenced this pull request Jul 17, 2020
@mikiquantum
Add support for Substrate Network on Key load (#87)
40b1b01 
* Revert "Add ExtrinsicSignatureV5 (#68)"

This reverts commit 461cf42.

* Add Support for network during key loading

* remove debug line

* added subkey + official image

* comment dockerfile

* Load network from env in test function
mikiquantum added a commit that referenced this pull request Aug 25, 2020
@mikiquantum
Add missing hasher - substrate rc3 version support (#89)
a5b9dc6 
* Revert "Add ExtrinsicSignatureV5 (#68)"

This reverts commit 461cf42.

* Add missing hasher

* review comments

* fix test
LeeSmet pushed a commit to LeeSmet/go-substrate-rpc-client that referenced this pull request Aug 28, 2020
@mikiquantum @LeeSmet
Add missing hasher - substrate rc3 version support (centrifuge#89)
3010561 
* Revert "Add ExtrinsicSignatureV5 (centrifuge#68)"

This reverts commit 461cf42.

* Add missing hasher

* review comments

* fix test
mikiquantum added a commit that referenced this pull request Sep 30, 2020
@mikiquantum
Add JSON unmarshal for subkey inspect (#98)
305d63b 
* Revert "Add ExtrinsicSignatureV5 (#68)"

This reverts commit 461cf42.

* Add JSON unmarshal for subkey inspect
@RaghavSood RaghavSood mentioned this pull request Sep 30, 2020
Closed
mikiquantum added a commit that referenced this pull request Nov 17, 2020
@mikiquantum
Add new events + types (#111)
be614e5 
* Revert "Add ExtrinsicSignatureV5 (#68)"

This reverts commit 461cf42.

* Added new events + types

* Add tests

* Remove fmt

* typo
mikiquantum added a commit that referenced this pull request Dec 15, 2020
@mikiquantum
Add new events + types (#111)
2ef025e 
* Revert "Add ExtrinsicSignatureV5 (#68)"

This reverts commit 461cf42.

* Added new events + types

* Add tests

* Remove fmt

* typo
mikiquantum added a commit that referenced this pull request Dec 15, 2020
@mikiquantum
Add new events + types (#111)
03102b8 
* Revert "Add ExtrinsicSignatureV5 (#68)"

This reverts commit 461cf42.

* Added new events + types

* Add tests

* Remove fmt

* typo
mikiquantum added a commit that referenced this pull request Dec 16, 2020
@mikiquantum
Fix council types (#122)
75ab0a0 
* Revert "Add ExtrinsicSignatureV5 (#68)"

This reverts commit 461cf42.

* Add Council new dispatch result event type
mikiquantum added a commit that referenced this pull request Dec 30, 2020
@mikiquantum
Remove constant unix cgo (#125)
f42aa12 
* Revert "Add ExtrinsicSignatureV5 (#68)"

This reverts commit 461cf42.

* rm const unix cgo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikiquantum mikiquantum mikiquantum approved these changes

@philipstanislaus philipstanislaus philipstanislaus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ansermino @philipstanislaus @mikiquantum