Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing hasher - substrate rc3 version support #89

Merged
merged 9 commits into from
Aug 25, 2020
Merged

Add missing hasher - substrate rc3 version support #89

merged 9 commits into from
Aug 25, 2020

Conversation

mikiquantum
Copy link
Contributor

@mikiquantum mikiquantum commented Aug 20, 2020 •
edited
Loading

Closes #81 and #82

@codecov
Copy link

codecov bot commented Aug 20, 2020 •
edited
Loading

Codecov Report

Merging #89 into master will decrease coverage by 0.14%.
The diff coverage is 45.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
- Coverage   60.50%   60.36%   -0.15%     
==========================================
  Files          88       90       +2     
  Lines        3618     3658      +40     
==========================================
+ Hits         2189     2208      +19     
- Misses       1074     1094      +20     
- Partials      355      356       +1
Impacted Files Coverage Δ
types/metadataV10.go 55.93% <10.00%> (-1.46%) ⬇️
hash/identity.go 30.76% <30.76%> (ø)
hash/blake2b.go 71.42% <71.42%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40b1b01...0916056. Read the comment docs.

@mikiquantum mikiquantum mentioned this pull request Aug 20, 2020
Closed
vedhavyas
vedhavyas approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@vedhavyas vedhavyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor improvement suggestions
Overall LGTM

hash/blake2b.go Outdated Show resolved Hide resolved
@mikiquantum mikiquantum changed the title Add missing hasher - newer substrate version support Add missing hasher - substrate rc3 version support Aug 20, 2020
vedhavyas
vedhavyas reviewed Aug 24, 2020
View reviewed changes
hash/blake2b.go Show resolved Hide resolved
hash/blake2b.go Show resolved Hide resolved
philipstanislaus
philipstanislaus approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@philipstanislaus philipstanislaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean, thanks!

@mikiquantum mikiquantum merged commit a5b9dc6 into centrifuge:master Aug 25, 2020
@mikiquantum mikiquantum deleted the add/hasher branch August 25, 2020 13:11
LeeSmet pushed a commit to LeeSmet/go-substrate-rpc-client that referenced this pull request Aug 28, 2020
@mikiquantum @LeeSmet
Add missing hasher - substrate rc3 version support (centrifuge#89)
3010561 
* Revert "Add ExtrinsicSignatureV5 (centrifuge#68)"

This reverts commit 461cf42.

* Add missing hasher

* review comments

* fix test
@ansermino ansermino mentioned this pull request Sep 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vedhavyas vedhavyas vedhavyas approved these changes

@philipstanislaus philipstanislaus philipstanislaus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NewSubstrateAPI error
3 participants
@mikiquantum @philipstanislaus @vedhavyas