Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve renewal instructions in the instruction generator #716

Merged
merged 4 commits into from
May 28, 2021

Conversation

ohemorange
Copy link
Contributor

@ohemorange ohemorange commented May 27, 2021

These changes are done to match our updated cli ux, our updated docs instructions, and feedback from the CISPA Usable Security group.

pip apache (cron not included, no certonly)
pip-apache

pip other (cron not included, certonly)
pip-other

snapd apache (cron included, no certonly)
ubuntu-no-certonly

snapd other (cron included, certonly)
snapd-certonly

This PR does not include the Windows instructions, which are hard-coded on their own in windows.html.

@ohemorange ohemorange changed the title Clean renewal Improve renewal instructions in the instruction generator May 27, 2021
Copy link
Collaborator

@alexzorin alexzorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we not showing pip users how to do a --dry-run in addition to setting up the cronjob?

Approving because this problem is in master already and I don't mind if we address it in a follow-up PR.

This otherwise LGTM.

@ohemorange ohemorange merged commit abb63d9 into master May 28, 2021
@ohemorange ohemorange deleted the clean-renewal branch May 28, 2021 20:12
@ohemorange
Copy link
Contributor Author

Follow-up PR is here: #718

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants