Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give both cron-included and non-cron-included users instructions on how to test using --dry-run #718

Merged
merged 4 commits into from
Jun 2, 2021

Conversation

ohemorange
Copy link
Contributor

@ohemorange ohemorange commented May 28, 2021

As pointed out here, we weren't showing users who needed to set up automatic renewal how to test their renewal setup. We should do that. Also, now that we always have users use directory hooks, we should have them test after they've set up the hooks.

Snap, apache (no certonly)
snap-apache2

Snap, none of the above (certonly)
snap-other2

Snap, haproxy (certonly)
snap-haproxy

Pip, apache (no certonly)
Screenshot from 2021-05-28 14-26-59

Pip, none of the above (certonly)
none-of-the-above

Pip, haproxy (certonly)
Screenshot from 2021-06-01 16-46-23

@ohemorange ohemorange changed the title Give both cron-included and non-cron-included users instructions on h… Give both cron-included and non-cron-included users instructions on how to test using --dry-run May 28, 2021
@ohemorange ohemorange requested a review from alexzorin May 28, 2021 21:29
@ohemorange ohemorange added instruction generator priority: significant Issues with higher than average priority that do not need to be in the current milestone. labels May 28, 2021
Copy link
Collaborator

@alexzorin alexzorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Given that our example use case for directory hooks is haproxy, it's a little odd that selecting haproxy/pip or haproxy/snapd doesn't show these instructions. Probably just due to the design of the generator.
  2. Are we putting the --dry-run instructions below the "directory hooks" instructions intentionally? My first reaction was that it takes a lot of reading to get to it. On the other hand, if it's important for the user to read all that, maybe it's fine as it is.

@ohemorange
Copy link
Contributor Author

  1. Oh no, what?? Yeah that looks like a bug. And we probably should fix Windows as well as some point, now that I'm looking through all our special-cased instructions that aren't just pulling from the file I updated here...

  2. Yes, that was intentional. My thought was that if they're testing, they should have it as close as possible to the final setup, including the hooks. I wasn't thinking about importance though, that's a good point. If we swap it, we probably want to tell them to run --dry-run again, what do you think?

@ohemorange
Copy link
Contributor Author

Well, now it looks a little weird that we're saying "if your webserver is haproxy" when we do know it is, I can fix that.

@ohemorange
Copy link
Contributor Author

travis??

@ohemorange ohemorange closed this Jun 1, 2021
@ohemorange ohemorange reopened this Jun 1, 2021
@ohemorange ohemorange force-pushed the show-pip-users-dry-run branch from eaf5e77 to aaef367 Compare June 1, 2021 23:36
@ohemorange
Copy link
Contributor Author

Updated screenshots in the top picture.

Copy link
Collaborator

@alexzorin alexzorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is pretty good.

Good catch with Windows. I created #720 to track that.

@alexzorin alexzorin merged commit 3065141 into master Jun 2, 2021
@alexzorin alexzorin deleted the show-pip-users-dry-run branch June 2, 2021 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
instruction generator priority: significant Issues with higher than average priority that do not need to be in the current milestone.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants