-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give both cron-included and non-cron-included users instructions on how to test using --dry-run #718
Conversation
…ow to test using --dry-run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Given that our example use case for directory hooks is haproxy, it's a little odd that selecting
haproxy/pip
orhaproxy/snapd
doesn't show these instructions. Probably just due to the design of the generator. - Are we putting the
--dry-run
instructions below the "directory hooks" instructions intentionally? My first reaction was that it takes a lot of reading to get to it. On the other hand, if it's important for the user to read all that, maybe it's fine as it is.
|
Well, now it looks a little weird that we're saying "if your webserver is haproxy" when we do know it is, I can fix that. |
travis?? |
eaf5e77
to
aaef367
Compare
Updated screenshots in the top picture. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is pretty good.
Good catch with Windows. I created #720 to track that.
As pointed out here, we weren't showing users who needed to set up automatic renewal how to test their renewal setup. We should do that. Also, now that we always have users use directory hooks, we should have them test after they've set up the hooks.
Snap, apache (no certonly)

Snap, none of the above (certonly)

Snap, haproxy (certonly)

Pip, apache (no certonly)

Pip, none of the above (certonly)

Pip, haproxy (certonly)
