Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added counter field and updated confirmation_id #473

Merged
merged 19 commits into from
Nov 15, 2024
Merged

Added counter field and updated confirmation_id #473

merged 19 commits into from
Nov 15, 2024

Conversation

jcadam14
Copy link
Contributor

Closes #472
Closes #460

Removed microseconds from timestamp
Added counter field to Submission table/DAO/DTO
Added alembic script to add field, add unique constraint for filing id and counter, and set existing submission counters
Updated add_submission to get the latest count and add 1, or start from 1 if new for the filing period
Updated pytests to test counter

@jcadam14 jcadam14 self-assigned this Oct 28, 2024
@jcadam14 jcadam14 linked an issue Oct 28, 2024 that may be closed by this pull request
Remove milli/microseconds from the signature confirmation id #460
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 28, 2024 •
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  src/sbl_filing_api/entities/models
  dao.py 44
  dto.py
  src/sbl_filing_api/entities/repos
  submission_repo.py
  src/sbl_filing_api/routers
  filing.py
  src/sbl_filing_api/services
  submission_processor.py
Project Total  

This report was generated by python-coverage-comment-action

@jcadam14 jcadam14 marked this pull request as draft October 28, 2024 19:33
@jcadam14 jcadam14 marked this pull request as ready for review October 28, 2024 20:10
@jcadam14 jcadam14 mentioned this pull request Oct 28, 2024
Merged
lchen-2101 pushed a commit that referenced this pull request Oct 29, 2024
@jcadam14
474 update is voluntary field to be nullable (#475)
71d24a3 
Closes #474 

Need to update either this or #473 due to each PR have an alembic
script, so will need to make whichever PR is reviewed/approved last
alembic based on the first PR merged in.
@jcadam14 jcadam14 mentioned this pull request Nov 7, 2024
Merged
lchen-2101
lchen-2101 previously approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@lchen-2101 lchen-2101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we're taking out the id = counter later after front end is done with their changes, right? Hopefully this doesn't clash with 394

@jcadam14
Copy link
Contributor Author

LGTM, we're taking out the id = counter later after front end is done with their changes, right? Hopefully this doesn't clash with 394

Yup, correct. I was waiting to see if they got their piece in prior to this being approved, but their story isn't assigned yet. So once this is merged in I'll write a story to remove the code that's copying the counter to the id.

@jcadam14 jcadam14 requested a review from lchen-2101 November 15, 2024 15:20
lchen-2101
lchen-2101 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@lchen-2101 lchen-2101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lchen-2101 lchen-2101 merged commit 918bc1e into main Nov 15, 2024
5 checks passed
@lchen-2101 lchen-2101 deleted the 460-remove-millimicroseconds-from-the-signature-confirmation-id branch November 15, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchen-2101 lchen-2101 lchen-2101 approved these changes

@hkeeler hkeeler Awaiting requested review from hkeeler

@guffee23 guffee23 Awaiting requested review from guffee23

@nargis-sultani nargis-sultani Awaiting requested review from nargis-sultani

Assignees

@jcadam14 jcadam14

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add counter field to Submission model Remove milli/microseconds from the signature confirmation id
2 participants
@jcadam14 @lchen-2101