Only spawn_blocking for tx creation in DA queue #1321
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It doesn't make much sense to spawn the whole DA queue in a spawn_blocking, due to the fact that it waits empty for messages most of the time, hence, it doesn't need a whole thread to itself. Instead, with this PR, queue is spawned as a tokio runtime worker, so it doesn't occupy any resources while waiting, but only acquires a thread with spawn_blocking when it's time to create the transaction and find the right prefix (or nonce).
Linked Issues
Testing
Describe how these changes were tested. If you've added new features, have you added unit tests?
Docs
Describe where this code is documented. If it changes a documented interface, have the docs been updated?