fix bugs regarding tx gas limit #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
ercecan,
jfldde,
kpp,
rakanalh and
yaziciahmet
eyusufatik
commented
Oct 10, 2024
yaziciahmet
reviewed
Oct 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
kpp
reviewed
Oct 11, 2024
ercecan
reviewed
Oct 11, 2024
ercecan
approved these changes
Oct 11, 2024
kpp
approved these changes
Oct 11, 2024
eyusufatik
added a commit
that referenced
this pull request
Oct 11, 2024
* only spawn_blocking for nonce search (#1321) * Use spawn_blocking in bitcoin service not in tx builders (#1324) * Use spawn_blocking in bitcoin service not in tx builders * Clone outside of spawn --------- Co-authored-by: yaziciahmet <[email protected]> * fix bugs regarding tx gas limit (#1323) * fix bugs regarding tx gas limit * group gas limit capping functionality to a function * prepare v0.5.4 (#1327) * update version number in doc and update changelog * update neglected CITREA_VERSION constant --------- Co-authored-by: Ahmet Yazıcı <[email protected]> Co-authored-by: Roman <[email protected]> Co-authored-by: yaziciahmet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The real "bug" turned out to be something different from my initial thoughts in the issue.
Linked Issues
Fixes #1322
Testing
Describe how these changes were tested. If you've added new features, have you added unit tests?
Docs
Describe where this code is documented. If it changes a documented interface, have the docs been updated?