Svelte menu + styles fix for Svelte #587
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
$:
to awritable
for the menu.$:
is a bit of a black box and does not always trigger reactivity as expected. Writable seems to have more reliable outputs with zag. Currently considering switching all the examples to writables.📝 Additional Information
I think it might be possible to handle everything with a single use directive, but i still need to test for reactivity in some edge cases, will come that with another PR.
IMPORTANT: Wait for (#589 ) to be merged before. ( Closing PR to reopen a new one targeting the other branch )