Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte menu + styles fix for Svelte #587

Closed
wants to merge 8 commits into from

Conversation

Shyrro
Copy link
Contributor

@Shyrro Shyrro commented Mar 31, 2023

📝 Description

  • Add menu example for Svelte
  • Don't spread styles and handle them in the spread directive to avoid collision between zag and svelte ( Tested with a SvelteKit app with both Select and Menu )
  • Rename "zag" directive to what it does
  • Try converting $: to a writable for the menu. $: is a bit of a black box and does not always trigger reactivity as expected. Writable seems to have more reliable outputs with zag. Currently considering switching all the examples to writables.

📝 Additional Information

I think it might be possible to handle everything with a single use directive, but i still need to test for reactivity in some edge cases, will come that with another PR.

IMPORTANT: Wait for (#589 ) to be merged before. ( Closing PR to reopen a new one targeting the other branch )

@changeset-bot
Copy link

changeset-bot bot commented Mar 31, 2023

⚠️ No Changeset found

Latest commit: 4f03f96

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package "svelte-ts" depends on the ignored package "@zag-js/shared", but "svelte-ts" is not being ignored. Please add "svelte-ts" to the `ignore` option.

@vercel
Copy link

vercel bot commented Mar 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
zag-nextjs ✅ Ready (Inspect) Visit Preview Mar 31, 2023 at 5:36PM (UTC)
zag-solid ✅ Ready (Inspect) Visit Preview Mar 31, 2023 at 5:36PM (UTC)
zag-vue ✅ Ready (Inspect) Visit Preview Mar 31, 2023 at 5:36PM (UTC)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants