-
-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add svelte kit app #589
feat: add svelte kit app #589
Conversation
Signed-off-by: Shyrro <[email protected]>
Signed-off-by: Zakaria Sahmane <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Shyrro <[email protected]>
8426be0
to
2fcbe2c
Compare
Looks great. So we can't use |
@anubra266 We can! We just need to include those packages in "ssr noExternal", otherwise Vite doesn't know how to resolve them in ssr |
@Shyrro I guess we just need to get rid of the current sandbox, and ensure the shared styling works here, then we can merge into the svelte branch. |
Signed-off-by: Shyrro <[email protected]>
📝 Description
Managed to make a SvelteKit app work within the pnpm workspace and resolve the deps + HMR correctly.
⛳️ Current behavior (updates)
Adding a SvelteKit app to the repo didn't work because of deps
🚀 New behavior
Deps now work in SvelteKit app in our pnpm workspace thanks to
ssr.noExternal
.📝 Additional Information
We now have a SvelteKit App to test the machines against. So we can develop the machines in confidence for SSR mode