Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add svelte kit app #589

Merged
merged 8 commits into from
Apr 2, 2023

Conversation

Shyrro
Copy link
Contributor

@Shyrro Shyrro commented Apr 1, 2023

📝 Description

Managed to make a SvelteKit app work within the pnpm workspace and resolve the deps + HMR correctly.

⛳️ Current behavior (updates)

Adding a SvelteKit app to the repo didn't work because of deps

🚀 New behavior

Deps now work in SvelteKit app in our pnpm workspace thanks to ssr.noExternal.

📝 Additional Information

We now have a SvelteKit App to test the machines against. So we can develop the machines in confidence for SSR mode

@changeset-bot
Copy link

changeset-bot bot commented Apr 1, 2023

⚠️ No Changeset found

Latest commit: b72ec45

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package "svelte-kit" depends on the ignored package "@zag-js/shared", but "svelte-kit" is not being ignored. Please add "svelte-kit" to the `ignore` option.

@vercel
Copy link

vercel bot commented Apr 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
zag-nextjs ✅ Ready (Inspect) Visit Preview Apr 2, 2023 7:29pm
zag-solid ✅ Ready (Inspect) Visit Preview Apr 2, 2023 7:29pm
zag-vue ✅ Ready (Inspect) Visit Preview Apr 2, 2023 7:29pm

@anubra266
Copy link
Collaborator

Looks great. So we can't use workspace:* instead of link

@Shyrro
Copy link
Contributor Author

Shyrro commented Apr 2, 2023

@anubra266 We can! We just need to include those packages in "ssr noExternal", otherwise Vite doesn't know how to resolve them in ssr

@anubra266
Copy link
Collaborator

@Shyrro I guess we just need to get rid of the current sandbox, and ensure the shared styling works here, then we can merge into the svelte branch.

@segunadebayo segunadebayo changed the title Feat/add svelte kit app feat: add svelte kit app Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants