-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create .nvmrc #1875
feat: create .nvmrc #1875
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome thanks for adding and fixing this! LGTM 🤩 👏
Codecov Report
@@ Coverage Diff @@
## main #1875 +/- ##
=======================================
Coverage 94.75% 94.75%
=======================================
Files 105 105
Lines 6925 6925
=======================================
Hits 6562 6562
Misses 363 363
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Looks like this patch didn't solve our needs, ongoing thread over here |
Reviewers
Functional: @tihuan
Readability: @danieljhegeman
Changes
.nvmrc
to set a standard version of node for nvm to useNotes:
Node v16 was needed for m1 support