Support node-sass@6 #28710

adrienharnay · 2021-09-01T14:34:55Z

This features supports node-sass@6, which supports node@16.

Addresses the discussion #28704 (comment)

timneutkens

Looks like this is breaking a bunch of tests.

adrienharnay · 2021-09-07T08:30:23Z

Hi @timneutkens, indeed it does! I will investigate but have never touched this part of the code before, so any help would be appreciated :)

adrienharnay · 2021-09-07T09:18:13Z

@timneutkens It seems I also needed to bump sass-loader to 10.2.0, which still supports Webpack@4, but also supports Node@16.
I ran some of the test suites that failed locally and they seem to pass know! Could you please approve the workflow to see if all the suites pass?
Thanks in advance 🙏

…node-sass-6

…xt.js into feat/support-node-sass-6

timneutkens · 2021-09-07T12:20:41Z

I've updated the precompiled dependency (sass-loader), then the tests should pass 👍

adrienharnay · 2021-09-07T12:29:15Z

Thank you! Could you please tell me how you did it? This way I will be able to do it myself next time :)

timneutkens · 2021-09-07T13:32:38Z

Thank you! Could you please tell me how you did it? This way I will be able to do it myself next time :)

We generally run these ourselves to ensure there's no compilation difference 👍

adrienharnay · 2021-09-07T14:02:49Z

I am under the impression the 2 remaining tests are not failing because of my changes. Can you confirm?

timneutkens · 2021-09-08T15:06:23Z

Correct!

timneutkens

Thanks! This looks good to land now 👍

ijjk · 2021-09-08T17:17:42Z

Failing test suites

Commit: bc7ffb7

test/integration/config-devtool-dev/test/index.test.js

devtool set in development mode in next config > should warn and revert when a devtool is set in development mode

Expand output

● devtool set in development mode in next config › should warn and revert when a devtool is set in development mode

thrown: "Exceeded timeout of 30000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

  11 | import webdriver from 'next-webdriver'
  12 | import { join } from 'path'
> 13 |
     | ^
  14 | jest.setTimeout(1000 * 30)
  15 |
  16 | const appDir = join(__dirname, '../')

  at integration/config-devtool-dev/test/index.test.js:13:5
  at Object.<anonymous> (integration/config-devtool-dev/test/index.test.js:12:1)

ijjk · 2021-09-08T17:17:47Z

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	adrienharnay/next.js feat/support-node-sass-6	Change
buildDuration	14.1s	14.3s	⚠️ +167ms
buildDurationCached	3.6s	3.6s	-73ms
nodeModulesSize	48.2 MB	48.2 MB	⚠️ +277 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	adrienharnay/next.js feat/support-node-sass-6	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.761	2.804	⚠️ +0.04
/ avg req/sec	905.32	891.62	⚠️ -13.7
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.499	1.482	-0.02
/error-in-render avg req/sec	1667.43	1687.38	+19.95

Client Bundles (main, webpack, commons)

	vercel/next.js canary	adrienharnay/next.js feat/support-node-sass-6	Change
745.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	23.3 kB	23.3 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	67.2 kB	67.2 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	adrienharnay/next.js feat/support-node-sass-6	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	adrienharnay/next.js feat/support-node-sass-6	Change
_app-HASH.js gzip	979 B	979 B	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	329 B	329 B	✓
dynamic-HASH.js gzip	2.67 kB	2.67 kB	✓
head-HASH.js gzip	351 B	351 B	✓
hooks-HASH.js gzip	918 B	918 B	✓
image-HASH.js gzip	4.14 kB	4.14 kB	✓
index-HASH.js gzip	261 B	261 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	318 B	318 B	✓
script-HASH.js gzip	387 B	387 B	✓
withRouter-HASH.js gzip	320 B	320 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	13 kB	13 kB	✓

Client Build Manifests

	vercel/next.js canary	adrienharnay/next.js feat/support-node-sass-6	Change
_buildManifest.js gzip	492 B	492 B	✓
Overall change	492 B	492 B	✓

Rendered Page Sizes

	vercel/next.js canary	adrienharnay/next.js feat/support-node-sass-6	Change
index.html gzip	539 B	539 B	✓
link.html gzip	552 B	552 B	✓
withRouter.html gzip	533 B	533 B	✓
Overall change	1.62 kB	1.62 kB	✓

Webpack 4 Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	adrienharnay/next.js feat/support-node-sass-6	Change
buildDuration	11.6s	11.6s	⚠️ +1ms
buildDurationCached	4.8s	4.8s	-15ms
nodeModulesSize	48.2 MB	48.2 MB	⚠️ +277 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	adrienharnay/next.js feat/support-node-sass-6	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.797	2.781	-0.02
/ avg req/sec	893.88	898.8	+4.92
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.497	1.517	⚠️ +0.02
/error-in-render avg req/sec	1670.45	1647.55	⚠️ -22.9

Client Bundles (main, webpack, commons)

	vercel/next.js canary	adrienharnay/next.js feat/support-node-sass-6	Change
16.HASH.js gzip	186 B	186 B	✓
677f882d2ed8..HASH.js gzip	14.1 kB	14.1 kB	✓
framework.HASH.js gzip	41.9 kB	41.9 kB	✓
main-HASH.js gzip	10.7 kB	10.7 kB	✓
webpack-HASH.js gzip	1.19 kB	1.19 kB	✓
Overall change	68.1 kB	68.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	adrienharnay/next.js feat/support-node-sass-6	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	adrienharnay/next.js feat/support-node-sass-6	Change
_app-HASH.js gzip	964 B	964 B	✓
_error-HASH.js gzip	3.8 kB	3.8 kB	✓
amp-HASH.js gzip	552 B	552 B	✓
css-HASH.js gzip	333 B	333 B	✓
dynamic-HASH.js gzip	2.87 kB	2.87 kB	✓
head-HASH.js gzip	3.06 kB	3.06 kB	✓
hooks-HASH.js gzip	924 B	924 B	✓
index-HASH.js gzip	231 B	231 B	✓
link-HASH.js gzip	1.64 kB	1.64 kB	✓
routerDirect..HASH.js gzip	298 B	298 B	✓
script-HASH.js gzip	3.03 kB	3.03 kB	✓
withRouter-HASH.js gzip	295 B	295 B	✓
30809af5c834..565.css gzip	125 B	125 B	✓
Overall change	18.1 kB	18.1 kB	✓

Client Build Manifests

	vercel/next.js canary	adrienharnay/next.js feat/support-node-sass-6	Change
_buildManifest.js gzip	500 B	500 B	✓
Overall change	500 B	500 B	✓

Rendered Page Sizes

	vercel/next.js canary	adrienharnay/next.js feat/support-node-sass-6	Change
index.html gzip	585 B	585 B	✓
link.html gzip	597 B	597 B	✓
withRouter.html gzip	578 B	578 B	✓
Overall change	1.76 kB	1.76 kB	✓

Commit: bc7ffb7

seve · 2022-01-25T22:23:27Z

I can't seem to find this commit on v11.1.3. Was this PR purposefully omitted from the v12.0.1 backport? The release notes are a bit vague, but looking deeper into it, it looks like only #32092 is featured in 11.1.3.

In order to get node v16 support is an update to at least 12.0.5?

Note: I can see the commit on v11.1.3-canary.105 Could it be possible that the commit was accidentally omitted?

balazsorban44 · 2022-02-10T11:17:04Z

Please see #34139 (comment)

support node-sass@6

088d7c9

adrienharnay requested review from huozhi, ijjk, padmaia, shuding, styfle and timneutkens as code owners September 1, 2021 14:34

ijjk added the type: next label Sep 1, 2021

This comment has been minimized.

Sign in to view

timneutkens requested changes Sep 2, 2021

View reviewed changes

adrienharnay added 2 commits September 7, 2021 10:42

Merge branch 'canary' into feat/support-node-sass-6

28e13ed

bump sass-loader

b0869b9

This comment has been minimized.

Sign in to view

timneutkens and others added 4 commits September 7, 2021 13:47

Merge branch 'canary' of github.com:vercel/next.js into feat/support-…

e66ee39

…node-sass-6

Merge branch 'canary' into feat/support-node-sass-6

bda4c84

Merge branch 'feat/support-node-sass-6' of github.com:adrienharnay/ne…

e43fa40

…xt.js into feat/support-node-sass-6

Update precompiled

ed3c042

This comment has been minimized.

Sign in to view

timneutkens approved these changes Sep 8, 2021

View reviewed changes

Merge branch 'canary' into feat/support-node-sass-6

b36e823

This comment has been minimized.

Sign in to view

Merge branch 'canary' into feat/support-node-sass-6

bc7ffb7

timneutkens merged commit 2abc4f2 into vercel:canary Sep 9, 2021

adrienharnay deleted the feat/support-node-sass-6 branch September 13, 2021 10:05

tihuan mentioned this pull request Sep 21, 2021

[Snyk] Security upgrade node-sass from 4.14.1 to 6.0.1 chanzuckerberg/single-cell-data-portal#1248

Closed

tihuan mentioned this pull request Dec 2, 2021

Upgrade next and node-sass to the latest version chanzuckerberg/single-cell-data-portal#1705

Closed

seve mentioned this pull request Jan 25, 2022

feat: create .nvmrc chanzuckerberg/single-cell-data-portal#1875

Closed

seve mentioned this pull request Feb 9, 2022

Potential improperly cut release for v11.1.3 #34139

Closed

github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support node-sass@6 #28710

Support node-sass@6 #28710

adrienharnay commented Sep 1, 2021

This comment has been minimized.

This comment has been minimized.

timneutkens left a comment

adrienharnay commented Sep 7, 2021

adrienharnay commented Sep 7, 2021

This comment has been minimized.

This comment has been minimized.

timneutkens commented Sep 7, 2021

adrienharnay commented Sep 7, 2021

This comment has been minimized.

timneutkens commented Sep 7, 2021

adrienharnay commented Sep 7, 2021

timneutkens commented Sep 8, 2021

timneutkens left a comment

This comment has been minimized.

ijjk commented Sep 8, 2021

ijjk commented Sep 8, 2021

seve commented Jan 25, 2022 •

edited

Loading

balazsorban44 commented Feb 10, 2022

Support node-sass@6 #28710

Support node-sass@6 #28710

Conversation

adrienharnay commented Sep 1, 2021

This comment has been minimized.

This comment has been minimized.

timneutkens left a comment

Choose a reason for hiding this comment

adrienharnay commented Sep 7, 2021

adrienharnay commented Sep 7, 2021

This comment has been minimized.

This comment has been minimized.

timneutkens commented Sep 7, 2021

adrienharnay commented Sep 7, 2021

This comment has been minimized.

timneutkens commented Sep 7, 2021

adrienharnay commented Sep 7, 2021

timneutkens commented Sep 8, 2021

timneutkens left a comment

Choose a reason for hiding this comment

This comment has been minimized.

ijjk commented Sep 8, 2021

Failing test suites

ijjk commented Sep 8, 2021

Stats from current PR

seve commented Jan 25, 2022 • edited Loading

balazsorban44 commented Feb 10, 2022

seve commented Jan 25, 2022 •

edited

Loading