Deprecate DateTime methods from issue #18846. #19955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate and rename DateTime methods from issue chapel-lang#18846. This has not yet modified the classes or enums suggested in that issue. Added a deprecated test to trigger the warnings for each of the deprecated methods. Signed-off-by: David Iten <[email protected]>
I missed these two in the last commit. Signed-off-by: David Iten <[email protected]>
Fix tests that were using the old all lowercase names. Signed-off-by: David Iten <[email protected]>
Fix tests that were using the old all lowercase names. Signed-off-by: David Iten <[email protected]>
benharsh
reviewed
Jun 8, 2022
| if tzinfo.borrow() == nil { | ||
| return new timedelta(); | ||
| } else { | ||
| return tzinfo!.utcOffset(datetime.now()); |
There was a problem hiding this comment.
Can this be called by the deprecated method?
There was a problem hiding this comment.
There are some other similar cases:
- fromTimestamp
- utcFromTimestamp
- fromOrdinal
- utcOffset
- fromUtc
There was a problem hiding this comment.
Thanks @benharsh! I replaced the bodies of the deprecated methods with calls to their replacements.
In order to reduce code duplication just call the new versions of deprecated methods. Signed-off-by: David Iten <[email protected]>
benharsh
approved these changes
Jun 8, 2022
3 tasks
jabraham17
added a commit
that referenced
this pull request
Jan 11, 2024
Removes a collection of previously deprecated symbols from the Time module. The removed symbols were deprecated in the following PRs: - #21826 - #22028 - #19955 - #21467 - #21034 - a subset of the symbols in #23114 Testing - [x] paratest without comm - [x] paratest with comm - [x] built and checked docs [Reviewd by @riftEmber]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate and rename DateTime methods from issue #18846. This has not yet
modified the classes or enums suggested in that issue.
Added a deprecated test to trigger the warnings for each of the deprecated
methods.
Fixed up any tests that were using the now-deprecated names.
Signed-off-by: David Iten [email protected]