Date time deprecate time units #21826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate the Time.TimeUnits enum and the functions that take an argument of that type. Update tests to stop using TimeUnits. Add a deprecated test that produces the new deprecation warnings. Signed-off-by: David Iten <[email protected]>
Update the deprecations in the Time module to use the new attribute syntax for marking them deprecated. Signed-off-by: David Iten <[email protected]>
daviditen
requested review from
bmcdonald3,
e-kayrakli and
dlongnecke-cray
and removed request for
bmcdonald3 and
e-kayrakli
dlongnecke-cray
approved these changes
Mar 9, 2023
| @@ -698,7 +698,7 @@ proc tcpListener.accept(in timeout: struct_timeval = indefiniteTimeout):tcpConn | |||
| if timeout.tv_sec:c_long != -1 { | |||
| var totalTimeout = timeout.tv_sec:c_long*1000000 + timeout.tv_usec:c_long; | |||
| // timer didn't elapsed | |||
| if totalTimeout > t.elapsed(TimeUnits.microseconds) { | |||
| if totalTimeout > (t.elapsed()*1_000_000) { | |||
There was a problem hiding this comment.
It would be cool if we could have a constant for this e.g., microsecondsPerSec = 1_000_000. Actually nevermind, I see we just use 1000000 everywhere else already...
3 tasks
jabraham17
added a commit
that referenced
this pull request
Jan 11, 2024
Removes a collection of previously deprecated symbols from the Time module. The removed symbols were deprecated in the following PRs: - #21826 - #22028 - #19955 - #21467 - #21034 - a subset of the symbols in #23114 Testing - [x] paratest without comm - [x] paratest with comm - [x] built and checked docs [Reviewd by @riftEmber]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate the Time.TimeUnits enum and the functions that use it
Deprecate the Time.TimeUnits enum and the functions that take an argument
of that type. Update tests to stop using TimeUnits.
Add a deprecated test that produces the new deprecation warnings.