-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Chef Environment Cookbooks constraints capitalisation #5089
Conversation
Signed-off-by: Vinay Sharma <[email protected]>
Deploy Preview for chef-automate processing. Building with commit a6f96a5 https://app.netlify.com/sites/chef-automate/deploys/60a7af8848a0a60008e965ee |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM , thanks @vinay033
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me
This is the same fix as #5089, but we also need to make sure that the attributes are not capitalized. Signed-off-by: Tim Smith <[email protected]>
This is the same fix as #5089, but we also need to make sure that the attributes are not capitalized. Signed-off-by: Tim Smith <[email protected]>
This is the same fix as #5089, but we also need to make sure that the attributes are not capitalized. Signed-off-by: Tim Smith <[email protected]>
Signed-off-by: Vinay Sharma [email protected]
🔩 Description: What code changed, and why?
Chef environment cookbook pins have the first letter of the cookbook automatically capitalized. The desired outcome is to have case processing on the cookbook names as created.
⛓️ Related Resources
#5079
👍 Definition of Done
I have added some minor changes to fix this.
👟 How to Build and Test the Change
To add data https://github.com/chef/automate/blob/master/dev-docs/adding-data/adding_test_data.md#adding-data-to-infra-views
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spell
in any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable