-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove TransitName and code used only by it #2604
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwachs5
commented
Jun 26, 2022
azidar
approved these changes
Jun 27, 2022
make valid compile
Change the pipe prefixing til it looks good
Show the new names
mwachs5
force-pushed
the
remove-transit-name
branch
from
June 27, 2022 17:08
ab8b1aa
to
a1c5bbf
Compare
seldridge
approved these changes
Jun 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm super happy to see this gone! 💯
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Checklist
docs/src
?Type of Improvement
API Impact
This removes the TransitName api deprecated in #2603. Should be merged after that one.
It also uses the naming plugin aPIs to get "good" names in the two usages of the TransitName API. It also "garbage collects" the
hook
related code that was only there for usage by TransitName.Backend Code Generation Impact
This will change the generated verilog for
Queue.apply()
andPipe.apply
, the only usages of TransitName in the codebase. I added unit tests that the names are still "good" and in fact much better than they were before IMHO.For example you can see the before (07495d5#diff-8dd923d131a5cad79defd56265f33df9037ac4e5169a46f4933f5a66935a7637R150 and after:08cd4c2 for Pipe:
Desired Merge Strategy
Release Notes
Remove TransitName API and code only used by it.
Reviewer Checklist (only modified by reviewer)
3.4.x
, [small] API extension:3.5.x
, API modification or big change:3.6.0
)?Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
.Create a merge commit
.