Use c++14 to pass the verilator check #3876
Conversation
The committers listed above are authorized under a signed CLA. |
seldridge
added
the
No Release Notes
There was a problem hiding this comment.
Generally seems fine to me. There shouldn't be an issue with requiring a compiler that supports C++14.
We haven't bumped the version of Tabby CAD OSS Suite in a while, so this likely hasn't cropped up. (We're using an older version of Verilator in CI.) We should probably do that, too, put that on latest, or add nightly/CD that tries to keep Tabby CAD up to date.
|
We should merge this, but a longer term fix is we should probably make the arguments version-specific so that we can support some older Linux distros and Verilator versions out-of-the-box. |
|
I also wouldn't call this "No release notes", we do now require a compiler with C++14 support which should work for most, but lots of users in the hardware industry are on surprisingly old Linux distros. |
seldridge
added
Dependency Update
|
@jackkoenig: Can we backport this and/or get this onto a non-snapshot release? I think this may be necessary for newer Verilator. I'm thinking this (chipsalliance/chisel-template#127) is related. |
(cherry picked from commit 6229155) # Conflicts: # svsim/src/main/scala/verilator/Backend.scala
(cherry picked from commit 6229155)
|
@seldridge sure, no reason not to release 6.2.0 (or 6.1.1?) with this. |
(cherry picked from commit 6229155) Co-authored-by: qimingchu <[email protected]>
* Use c++14 to pass the verilator check (#3876) (cherry picked from commit 6229155) # Conflicts: # svsim/src/main/scala/verilator/Backend.scala * Resolve backport conflicts --------- Co-authored-by: qimingchu <[email protected]> Co-authored-by: Jack Koenig <[email protected]>
When I update to verilator v5.022, the svsim test will fail (someone has already raised an issue). I found out this was because verilator added a check for the c++14 standard.
Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
Change ChiselSim to requires a C++14 compiler.
Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.